Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove types QueryMode, QueryPlan, ResultSetStats #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix: remove types QueryMode, QueryPlan, ResultSetStats #1304

merged 5 commits into from
Jan 30, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 25, 2024 •
edited by kolea2
Loading

  • Regenerate this pull request now.

fix: remove QueryMode field from RunQueryRequest
fix: remove ResultSetStats field from RunQueryResponse
fix: remove QueryMode field from RunAggregationQueryRequest
fix: remove ResultSetStats field from RunAggregationQueryResponse

PiperOrigin-RevId: 601486345

Source-Link: googleapis/googleapis@4a6230d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/db652ee83ed65816ec6d910d965458d684a31c73
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI2NTJlZTgzZWQ2NTgxNmVjNmQ5MTBkOTY1NDU4ZDY4NGEzMWM3MyJ9

@gcf-owl-bot
fix!: remove types QueryMode, QueryPlan, ResultSetStats
6838574 
fix!: remove QueryMode field from RunQueryRequest
fix!: remove ResultSetStats field from RunQueryResponse
fix!: remove QueryMode field from RunAggregationQueryRequest
fix!: remove ResultSetStats field from RunAggregationQueryResponse

PiperOrigin-RevId: 601486345

Source-Link: googleapis/googleapis@4a6230d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/db652ee83ed65816ec6d910d965458d684a31c73
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI2NTJlZTgzZWQ2NTgxNmVjNmQ5MTBkOTY1NDU4ZDY4NGEzMWM3MyJ9
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 25, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 25, 2024
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 25, 2024 19:54
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 25, 2024 19:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 25, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2024
@suztomo
Copy link
Member

suztomo commented Jan 25, 2024

@kolea2 As per b/321794555 (referenced by cl/601486345), I would remove all "!" in the title and commit message.

@kolea2 kolea2 changed the title fix!: remove types QueryMode, QueryPlan, ResultSetStats fix: remove types QueryMode, QueryPlan, ResultSetStats Jan 26, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@kolea2
Copy link
Contributor

kolea2 commented Jan 29, 2024

@suztomo I had to update the clirr config to get the build to pass, would you mind taking a look?

@suztomo
Copy link
Member

suztomo commented Jan 29, 2024

In a comment, would you write down rationale that this won't break library users' code? (such as interfaces not to be implemented by library users)

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 29, 2024
@kolea2
Copy link
Contributor

kolea2 commented Jan 29, 2024

@suztomo thanks, I just added a comment!

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@suztomo
Copy link
Member

suztomo commented Jan 30, 2024

Thank you!

@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 30, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c1e7c62 into main Jan 30, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch January 30, 2024 15:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 30, 2024
@release-please release-please bot mentioned this pull request Jan 30, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 1, 2024
@release-please
chore(main): release 2.18.3 (#1308)
bd28f91 
🤖 I have created a release *beep* *boop*
---


## [2.18.3](https://togithub.com/googleapis/java-datastore/compare/v2.18.2...v2.18.3) (2024-02-01)


### Bug Fixes

* Remove QueryMode field from RunAggregationQueryRequest ([c1e7c62](https://togithub.com/googleapis/java-datastore/commit/c1e7c6201e0e35469df1492a4ce61bf6a095f8be))
* Remove QueryMode field from RunQueryRequest ([c1e7c62](https://togithub.com/googleapis/java-datastore/commit/c1e7c6201e0e35469df1492a4ce61bf6a095f8be))
* Remove ResultSetStats field from RunAggregationQueryResponse ([c1e7c62](https://togithub.com/googleapis/java-datastore/commit/c1e7c6201e0e35469df1492a4ce61bf6a095f8be))
* Remove ResultSetStats field from RunQueryResponse ([c1e7c62](https://togithub.com/googleapis/java-datastore/commit/c1e7c6201e0e35469df1492a4ce61bf6a095f8be))
* Remove types QueryMode, QueryPlan, ResultSetStats ([#1304](https://togithub.com/googleapis/java-datastore/issues/1304)) ([c1e7c62](https://togithub.com/googleapis/java-datastore/commit/c1e7c6201e0e35469df1492a4ce61bf6a095f8be))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.24.0 ([#1310](https://togithub.com/googleapis/java-datastore/issues/1310)) ([26e5f98](https://togithub.com/googleapis/java-datastore/commit/26e5f9873c4df1815406020a6c22e4a20638f959))
* Update protobuf to 25.2 in WORKSPACE ([#1311](https://togithub.com/googleapis/java-datastore/issues/1311)) ([3f4ae83](https://togithub.com/googleapis/java-datastore/commit/3f4ae83b20f160eaccd9de17582d54d8222dd015))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

+1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suztomo @kolea2 @yoshi-kokoro