diff --git a/.kokoro/build.sh b/.kokoro/build.sh index 531270eab3..3fd2f578b5 100755 --- a/.kokoro/build.sh +++ b/.kokoro/build.sh @@ -91,7 +91,6 @@ samples) pushd ${SAMPLES_DIR} mvn -B \ - -Penable-samples \ -ntp \ -DtrimStackTrace=false \ -Dclirr.skip=true \ diff --git a/CHANGELOG.md b/CHANGELOG.md index 19941e75c6..9e7d58236a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +### [3.0.9](https://www.github.com/googleapis/java-firestore/compare/v3.0.8...v3.0.9) (2021-12-03) + + +### Dependencies + +* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#825](https://www.github.com/googleapis/java-firestore/issues/825)) ([1b8e3a3](https://www.github.com/googleapis/java-firestore/commit/1b8e3a38f722050d917643043bf4a8eb101c4200)) + ### [3.0.8](https://www.github.com/googleapis/java-firestore/compare/v3.0.7...v3.0.8) (2021-11-16) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f2dbdee06b..b65dd279c9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -53,12 +53,12 @@ mvn -Penable-integration-tests clean verify ## Code Samples -Code Samples must be bundled in separate Maven modules, and guarded by a -Maven profile with the name `enable-samples`. +All code samples must be in compliance with the [java sample formatting guide][3]. +Code Samples must be bundled in separate Maven modules. The samples must be separate from the primary project for a few reasons: -1. Primary projects have a minimum Java version of Java 7 whereas samples have - a minimum Java version of Java 8. Due to this we need the ability to +1. Primary projects have a minimum Java version of Java 8 whereas samples can have + Java version of Java 11. Due to this we need the ability to selectively exclude samples from a build run. 2. Many code samples depend on external GCP services and need credentials to access the service. @@ -68,39 +68,16 @@ The samples must be separate from the primary project for a few reasons: ### Building ```bash -mvn -Penable-samples clean verify +mvn clean verify ``` Some samples require access to GCP services and require a service account: ```bash export GOOGLE_APPLICATION_CREDENTIALS=/path/to/service/account.json -mvn -Penable-samples clean verify +mvn clean verify ``` -### Profile Config - -1. To add samples in a profile to your Maven project, add the following to your -`pom.xml` - - ```xml - - [...] - - - enable-samples - - sample - - - - [...] - - ``` - -2. [Activate](#profile-activation) the profile. -3. Define your samples in a normal Maven project in the `samples/` directory. - ### Code Formatting Code in this repo is formatted with @@ -110,30 +87,6 @@ To run formatting on your project, you can run: mvn com.coveo:fmt-maven-plugin:format ``` -### Profile Activation - -To include code samples when building and testing the project, enable the -`enable-samples` Maven profile. - -#### Command line - -To activate the Maven profile on the command line add `-Penable-samples` to your -Maven command. - -#### Maven `settings.xml` - -To activate the Maven profile in your `~/.m2/settings.xml` add an entry of -`enable-samples` following the instructions in [Active Profiles][2]. - -This method has the benefit of applying to all projects you build (and is -respected by IntelliJ IDEA) and is recommended if you are going to be -contributing samples to several projects. - -#### IntelliJ IDEA - -To activate the Maven Profile inside IntelliJ IDEA, follow the instructions in -[Activate Maven profiles][3] to activate `enable-samples`. - [1]: https://cloud.google.com/docs/authentication/getting-started#creating_a_service_account [2]: https://maven.apache.org/settings.html#Active_Profiles -[3]: https://www.jetbrains.com/help/idea/work-with-maven-profiles.html#activate_maven_profiles +[3]: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md \ No newline at end of file diff --git a/google-cloud-firestore-admin/pom.xml b/google-cloud-firestore-admin/pom.xml index 66ab75dc80..f810766a3c 100644 --- a/google-cloud-firestore-admin/pom.xml +++ b/google-cloud-firestore-admin/pom.xml @@ -4,7 +4,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 google-cloud-firestore-admin - 3.0.8 + 3.0.9 jar Google Cloud Firestore Admin Client https://github.com/googleapis/java-firestore @@ -14,7 +14,7 @@ com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/google-cloud-firestore-bom/pom.xml b/google-cloud-firestore-bom/pom.xml index c0fb126fe1..83eb021a3e 100644 --- a/google-cloud-firestore-bom/pom.xml +++ b/google-cloud-firestore-bom/pom.xml @@ -3,12 +3,12 @@ 4.0.0 com.google.cloud google-cloud-firestore-bom - 3.0.8 + 3.0.9 pom com.google.cloud google-cloud-shared-config - 1.2.1 + 1.2.2 Google Cloud Firestore BOM @@ -52,37 +52,37 @@ com.google.cloud google-cloud-firestore - 3.0.8 + 3.0.9 com.google.api.grpc proto-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 com.google.cloud proto-google-cloud-firestore-bundle-v1 - 3.0.8 + 3.0.9 com.google.api.grpc proto-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 com.google.api.grpc grpc-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 com.google.api.grpc grpc-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 com.google.cloud google-cloud-firestore-admin - 3.0.8 + 3.0.9 diff --git a/google-cloud-firestore/pom.xml b/google-cloud-firestore/pom.xml index fe09785eaa..0fa93bf249 100644 --- a/google-cloud-firestore/pom.xml +++ b/google-cloud-firestore/pom.xml @@ -4,7 +4,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 google-cloud-firestore - 3.0.8 + 3.0.9 jar Google Cloud Firestore https://github.com/googleapis/java-firestore @@ -14,7 +14,7 @@ com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 google-cloud-firestore diff --git a/grpc-google-cloud-firestore-admin-v1/pom.xml b/grpc-google-cloud-firestore-admin-v1/pom.xml index 45977d80c8..ecc90c724f 100644 --- a/grpc-google-cloud-firestore-admin-v1/pom.xml +++ b/grpc-google-cloud-firestore-admin-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc grpc-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 grpc-google-cloud-firestore-admin-v1 GRPC library for grpc-google-cloud-firestore-admin-v1 com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/grpc-google-cloud-firestore-v1/pom.xml b/grpc-google-cloud-firestore-v1/pom.xml index a142b1c114..efdd78db29 100644 --- a/grpc-google-cloud-firestore-v1/pom.xml +++ b/grpc-google-cloud-firestore-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc grpc-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 grpc-google-cloud-firestore-v1 GRPC library for grpc-google-cloud-firestore-v1 com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/pom.xml b/pom.xml index 6bc797a32e..2a5a7e7177 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ com.google.cloud google-cloud-firestore-parent pom - 3.0.8 + 3.0.9 Google Cloud Firestore Parent https://github.com/googleapis/java-firestore @@ -14,7 +14,7 @@ com.google.cloud google-cloud-shared-config - 1.2.1 + 1.2.2 @@ -150,33 +150,33 @@ com.google.api.grpc proto-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 com.google.cloud proto-google-cloud-firestore-bundle-v1 - 3.0.8 + 3.0.9 com.google.api.grpc proto-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 com.google.api.grpc grpc-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 com.google.api.grpc grpc-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 com.google.cloud google-cloud-shared-dependencies - 2.5.0 + 2.5.1 pom import diff --git a/proto-google-cloud-firestore-admin-v1/pom.xml b/proto-google-cloud-firestore-admin-v1/pom.xml index d4ff83658e..84cc4ab79e 100644 --- a/proto-google-cloud-firestore-admin-v1/pom.xml +++ b/proto-google-cloud-firestore-admin-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc proto-google-cloud-firestore-admin-v1 - 3.0.8 + 3.0.9 proto-google-cloud-firestore-admin-v1 PROTO library for proto-google-cloud-firestore-admin-v1 com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/proto-google-cloud-firestore-bundle-v1/pom.xml b/proto-google-cloud-firestore-bundle-v1/pom.xml index 4cf6601e50..6b9268069c 100644 --- a/proto-google-cloud-firestore-bundle-v1/pom.xml +++ b/proto-google-cloud-firestore-bundle-v1/pom.xml @@ -5,14 +5,14 @@ 4.0.0 proto-google-cloud-firestore-bundle-v1 - 3.0.8 + 3.0.9 proto-google-cloud-firestore-bundle-v1 PROTO library for proto-google-cloud-firestore-bundle-v1 com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/proto-google-cloud-firestore-v1/pom.xml b/proto-google-cloud-firestore-v1/pom.xml index fe96e1b1b1..d3d77e26ff 100644 --- a/proto-google-cloud-firestore-v1/pom.xml +++ b/proto-google-cloud-firestore-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc proto-google-cloud-firestore-v1 - 3.0.8 + 3.0.9 proto-google-cloud-firestore-v1 PROTO library for proto-google-cloud-firestore-v1 com.google.cloud google-cloud-firestore-parent - 3.0.8 + 3.0.9 diff --git a/samples/install-without-bom/pom.xml b/samples/install-without-bom/pom.xml index 6d63d3fc3a..2f5331a25f 100644 --- a/samples/install-without-bom/pom.xml +++ b/samples/install-without-bom/pom.xml @@ -29,7 +29,7 @@ com.google.cloud google-cloud-firestore - 3.0.7 + 3.0.8 diff --git a/samples/snapshot/pom.xml b/samples/snapshot/pom.xml index 5e7577bf96..42b0d27ee4 100644 --- a/samples/snapshot/pom.xml +++ b/samples/snapshot/pom.xml @@ -28,7 +28,7 @@ com.google.cloud google-cloud-firestore - 3.0.7 + 3.0.8 diff --git a/synth.metadata b/synth.metadata index 0687dd386e..13c08681a1 100644 --- a/synth.metadata +++ b/synth.metadata @@ -4,7 +4,7 @@ "git": { "name": ".", "remote": "https://github.com/googleapis/java-firestore.git", - "sha": "de7a882b642f6bde718dbc926c20be1195f963aa" + "sha": "36cd665ece8f3efbcad4e7fea889d4a3131f1b4e" } }, { @@ -19,7 +19,7 @@ "git": { "name": "synthtool", "remote": "https://github.com/googleapis/synthtool.git", - "sha": "42a3786737c17ece39924d7025f3be481812da53" + "sha": "7a7c48f96e90d1cdc3ab0cc8293279fdcb10fd36" } } ], diff --git a/versions.txt b/versions.txt index 7014a27e59..a82471f7e4 100644 --- a/versions.txt +++ b/versions.txt @@ -1,11 +1,11 @@ # Format: # module:released-version:current-version -google-cloud-firestore:3.0.8:3.0.8 -google-cloud-firestore-admin:3.0.8:3.0.8 -google-cloud-firestore-bom:3.0.8:3.0.8 -google-cloud-firestore-parent:3.0.8:3.0.8 -grpc-google-cloud-firestore-admin-v1:3.0.8:3.0.8 -grpc-google-cloud-firestore-v1:3.0.8:3.0.8 -proto-google-cloud-firestore-admin-v1:3.0.8:3.0.8 -proto-google-cloud-firestore-v1:3.0.8:3.0.8 +google-cloud-firestore:3.0.9:3.0.9 +google-cloud-firestore-admin:3.0.9:3.0.9 +google-cloud-firestore-bom:3.0.9:3.0.9 +google-cloud-firestore-parent:3.0.9:3.0.9 +grpc-google-cloud-firestore-admin-v1:3.0.9:3.0.9 +grpc-google-cloud-firestore-v1:3.0.9:3.0.9 +proto-google-cloud-firestore-admin-v1:3.0.9:3.0.9 +proto-google-cloud-firestore-v1:3.0.9:3.0.9