Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit c7f63bd

Browse files
committed
Address review comments
1 parent 7ec7832 commit c7f63bd

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

google/api_core/bidi.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,9 @@ def add_done_callback(self, callback):
265265
self._callbacks.append(callback)
266266

267267
def _on_call_done(self, future):
268+
# Note that grpc's "future" here is also a grpc.RpcError.
269+
# `grpc.RpcError` is also `grpc.call` based on
270+
# https://github.com/grpc/grpc/issues/10885#issuecomment-302651331
268271
for callback in self._callbacks:
269272
callback(future)
270273

0 commit comments

Comments
 (0)