address review feedback

parthea · parthea · commit dc338495299f · 2024-10-22T14:19:59.000Z
diff --git a/google/api_core/protobuf_helpers.py b/google/api_core/protobuf_helpers.py
@@ -63,7 +63,7 @@ def from_any_pb(pb_type, any_pb):
     # Unpack the Any object and populate the protobuf message instance.
     if not any_pb.Unpack(msg_pb):
         raise TypeError(
-            f"Could not convert `google.protobuf.any_pb2.Any` with underlying type `{any_pb.TypeName()}` to `{msg_pb.DESCRIPTOR.full_name}`"
+            f"Could not convert `{any_pb.TypeName()}` with underlying type `google.protobuf.any_pb2.Any` to `{msg_pb.DESCRIPTOR.full_name}`"
         )
 
     # Done; return the message.
diff --git a/tests/unit/test_protobuf_helpers.py b/tests/unit/test_protobuf_helpers.py
@@ -69,7 +69,7 @@ def test_from_any_pb_failure():
     with pytest.raises(
         TypeError,
         match=re.escape(
-            "Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"
+            "Could not convert `google.type.Date` with underlying type `google.protobuf.any_pb2.Any` to `google.type.TimeOfDay`"
         ),
     ):
         protobuf_helpers.from_any_pb(timeofday_pb2.TimeOfDay, in_message)

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ def from_any_pb(pb_type, any_pb):`
`63`	`63`	`# Unpack the Any object and populate the protobuf message instance.`
`64`	`64`	`if not any_pb.Unpack(msg_pb):`
`65`	`65`	`raise TypeError(`
`66`		- f"Could not convert `google.protobuf.any_pb2.Any` with underlying type `{any_pb.TypeName()}` to `{msg_pb.DESCRIPTOR.full_name}`"
	`66`	+ f"Could not convert `{any_pb.TypeName()}` with underlying type `google.protobuf.any_pb2.Any` to `{msg_pb.DESCRIPTOR.full_name}`"
`67`	`67`	`)`
`68`	`68`
`69`	`69`	`# Done; return the message.`