From d06aa7618fb322064847686da9bc5e7da1d58327 Mon Sep 17 00:00:00 2001 From: ohmayr Date: Fri, 20 Sep 2024 19:26:44 +0000 Subject: [PATCH 1/2] fix: set chunk size for async stream content --- google/api_core/rest_streaming_async.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/api_core/rest_streaming_async.py b/google/api_core/rest_streaming_async.py index d1f996f6..1de26b1f 100644 --- a/google/api_core/rest_streaming_async.py +++ b/google/api_core/rest_streaming_async.py @@ -49,7 +49,7 @@ def __init__( ): self._response = response self._chunk_size = 1024 - self._response_itr = self._response.content().__aiter__() + self._response_itr = self._response.content(self._chunk_size).__aiter__() super(AsyncResponseIterator, self).__init__( response_message_cls=response_message_cls ) From 4b960e34159b97a956ff07596a0a4fb8b8695729 Mon Sep 17 00:00:00 2001 From: ohmayr Date: Fri, 20 Sep 2024 19:58:37 +0000 Subject: [PATCH 2/2] add TODO comment --- google/api_core/rest_streaming_async.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/google/api_core/rest_streaming_async.py b/google/api_core/rest_streaming_async.py index 1de26b1f..812854c5 100644 --- a/google/api_core/rest_streaming_async.py +++ b/google/api_core/rest_streaming_async.py @@ -49,7 +49,11 @@ def __init__( ): self._response = response self._chunk_size = 1024 - self._response_itr = self._response.content(self._chunk_size).__aiter__() + # TODO(https://github.com/googleapis/python-api-core/issues/703): mypy does not recognize the abstract content + # method as an async generator as it looks for the `yield` keyword in the implementation. + # Given that the abstract method is not implemented, mypy fails to recognize it as an async generator. + # mypy warnings are silenced until the linked issue is resolved. + self._response_itr = self._response.content(self._chunk_size).__aiter__() # type: ignore super(AsyncResponseIterator, self).__init__( response_message_cls=response_message_cls )