Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jli
Copy link
Contributor

@jli jli commented Apr 14, 2022

(I didn't file an issue for this because it's small) 🦕

My team programmatically creates externally partitioned tables and they hold some of our most core deliverables - they're working great! We followed the sample code here: https://cloud.google.com/bigquery/docs/samples/bigquery-create-table-external-hivepartitioned#bigquery_create_table_external_hivepartitioned-python

But Pylance complains about this line:

hive_partitioning_opts = bigquery.external_config.HivePartitioningOptions()

"external_config" is not a known member of module

It seems like most of the other *Options classes are exported directly, so this does the same for HivePartitioningOptions.

@jli jli requested a review from a team April 14, 2022 04:45
@jli jli requested review from a team as code owners April 14, 2022 04:45
@jli jli requested review from dandhlee and shollyman April 14, 2022 04:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 14, 2022
@shollyman shollyman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2022
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catch, and the contribution!

Looks like there's a test failure in our prerelease testing, but it's unrelated to this PR. I'll go ahead and merge.

@shollyman shollyman merged commit 8eb757b into googleapis:main Apr 14, 2022
@jli jli deleted the john/export-hivepartopt branch April 19, 2022 23:41
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants