Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix broken multiindex loc cases #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 19, 2024
Merged

fix: fix broken multiindex loc cases #467

merged 6 commits into from
Mar 19, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners March 19, 2024 03:29
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 19, 2024
@TrevorBergeron TrevorBergeron requested review from milkshakeiii and removed request for Genesis929 March 19, 2024 03:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 19, 2024
milkshakeiii
milkshakeiii approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@milkshakeiii milkshakeiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced the complexity a little, too. Nice. Thanks!

@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit b519197 into main Mar 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the multi_loc branch March 19, 2024 19:54
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2024
@release-please release-please bot mentioned this pull request Mar 19, 2024
Merged
TrevorBergeron added a commit that referenced this pull request Mar 20, 2024
@TrevorBergeron
fix: fix broken multiindex loc cases (#467)
7bd6820 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @milkshakeiii