Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Product operation produces float result for all input types #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 26, 2024
Merged

fix: Product operation produces float result for all input types #501

merged 8 commits into from
Mar 26, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners March 22, 2024 23:23
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 22, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 22, 2024
@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Mar 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6873b30 into main Mar 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the float_prod branch March 26, 2024 20:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 26, 2024
@release-please release-please bot mentioned this pull request Mar 26, 2024
Merged
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@TrevorBergeron @Genesis929
fix: Product operation produces float result for all input types (#501)
62a63f5 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @milkshakeiii