Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Guarantee guid thread safety across threads #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

fix: Guarantee guid thread safety across threads #1684

merged 2 commits into from
May 5, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners May 2, 2025 00:07
@TrevorBergeron TrevorBergeron requested a review from tswast May 2, 2025 00:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 2, 2025
tswast
tswast approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like increment is not one of the atomic operations in Python. https://docs.python.org/2/faq/library.html#what-kinds-of-global-value-mutation-are-thread-safe

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) May 5, 2025 18:02
@TrevorBergeron TrevorBergeron merged commit cb0267d into main May 5, 2025
18 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the threadsafe_guids branch May 5, 2025 18:32
@release-please release-please bot mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @jialuoo