Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support fine-grained permissions database roles in connect #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 7, 2025
Merged

feat: support fine-grained permissions database roles in connect #1338

merged 13 commits into from
May 7, 2025

Conversation

waltaskew
Copy link
Contributor

@waltaskew waltaskew commented Apr 21, 2025 •
edited
Loading

Add an optional database_role argument to connect for supplying the database role to connect as when using
fine-grained access controls

Fixes #1337 🦕

@waltaskew
feat: support fine-grained permissions database roles in connect
9b4a15a 
Add an optional `database_role` argument to `connect` for supplying
the database role to connect as when using
[fine-grained access controls](https://cloud.google.com/spanner/docs/access-with-fgac)
@waltaskew waltaskew requested review from a team as code owners April 21, 2025 18:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Apr 21, 2025
@waltaskew
feat: support fine-grained permissions database roles in connect
b1bb422 
Add an optional `database_role` argument to `connect` for supplying
the database role to connect as when using
[fine-grained access controls](https://cloud.google.com/spanner/docs/access-with-fgac)
@olavloite olavloite assigned olavloite and unassigned surbhigarg92 Apr 21, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@waltaskew
Copy link
Contributor Author

@olavloite do you know what's going on with the 401 errors in the build? I wouldn't expect they're coming from my change?

@olavloite
Copy link
Contributor

@olavloite do you know what's going on with the 401 errors in the build? I wouldn't expect they're coming from my change?

Yeah, those are happening for other PRs as well, and are unrelated to your change.

@waltaskew waltaskew mentioned this pull request Apr 29, 2025
Closed
@rahul2393 rahul2393 enabled auto-merge (squash) April 30, 2025 17:46
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 6, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2025
@rahul2393 rahul2393 merged commit 064d9dc into googleapis:main May 7, 2025
11 of 19 checks passed
@release-please release-please bot mentioned this pull request May 7, 2025
Merged
@olavloite olavloite mentioned this pull request May 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Database Roles for Fine-Grained Access Controls When Connecting
5 participants
@waltaskew @olavloite @surbhigarg92 @rahul2393 @yoshi-kokoro