Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: enable support for get_key_columns and cleanup tests with unknown failures to specific failures. #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 13, 2021
Merged

feat: enable support for get_key_columns and cleanup tests with unknown failures to specific failures. #721

merged 12 commits into from
Oct 13, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Oct 11, 2021 •
edited
Loading

feat: enable support for get_key_columns and cleanup tests with unknown failures to specific failures.

Note: ON DELETE CASCADE is not supported still for Foreign key, so this feature is not full fledged yet.

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner October 11, 2021 15:21
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Oct 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@vi3k6i5 vi3k6i5 changed the title feat: enable support for foreign key and enable related tests. feat: enable support for get_key_columns and cleanup tests with unknown failures to specific failures. Oct 12, 2021
@vi3k6i5 vi3k6i5 requested a review from asthamohta October 12, 2021 12:28
asthamohta
asthamohta reviewed Oct 12, 2021
View reviewed changes
asthamohta
asthamohta approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@vi3k6i5 vi3k6i5 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@vi3k6i5 vi3k6i5 merged commit 1ec0784 into googleapis:main Oct 13, 2021
This was referenced Apr 17, 2024
Closed
Closed
This was referenced Apr 18, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asthamohta asthamohta asthamohta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vi3k6i5 @asthamohta @yoshi-kokoro