Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[samplecode][2/3]Implemente Unary Paged RPC method's sample code #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Dec 10, 2020
Merged

[samplecode][2/3]Implemente Unary Paged RPC method's sample code #576

merged 34 commits into from
Dec 10, 2020

Conversation

summer-ji-eng
Copy link
Contributor

Unary Paged RPC method with method signatures

  * try (LoggingClient loggingClient = LoggingClient.create()) {
   *   List<String> formattedResourceNames = new ArrayList<>();
   *   String filter = "";
   *   String orderBy = "";
   *   for (LogEntry element : loggingClient.listLogEntries(formattedResourceNames, filter, orderBy).iterateAll()) {
   *     // doThingsWith(element);
   *   }
   * }

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2020
@summer-ji-eng summer-ji-eng changed the title [composer][2/3]Implemente Unary Paged RPC method's sample code [2/3]Implemente Unary Paged RPC method's sample code Nov 30, 2020
miraleung
miraleung suggested changes Nov 30, 2020
View reviewed changes
src/test/java/com/google/api/generator/gapic/composer/ServiceClientSampleCodeComposerTest.java
import org.junit.Assert;
import org.junit.Test;

public class ServiceClientSampleCodeComposerTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review the test once the other comments have been addressed.

@summer-ji-eng summer-ji-eng mentioned this pull request Dec 1, 2020
Closed
@summer-ji-eng summer-ji-eng changed the title [2/3]Implemente Unary Paged RPC method's sample code [samplecode][2/3]Implemente Unary Paged RPC method's sample code Dec 2, 2020
@summer-ji-eng summer-ji-eng changed the title [samplecode][2/3]Implemente Unary Paged RPC method's sample code [Need Refactor][2/3]Implemente Unary Paged RPC method's sample code Dec 3, 2020
@summer-ji-eng summer-ji-eng changed the title [Need Refactor][2/3]Implemente Unary Paged RPC method's sample code [samplecode][2/3]Implemente Unary Paged RPC method's sample code Dec 5, 2020
@summer-ji-eng summer-ji-eng force-pushed the paged_unary_rpc_2 branch 2 times, most recently from 2deae52 to c3ee114 Compare December 6, 2020 01:08
@miraleung miraleung mentioned this pull request Dec 8, 2020
Merged
miraleung
miraleung suggested changes Dec 8, 2020
View reviewed changes
miraleung
miraleung suggested changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with parameter ordering and method renaming comments addressed.

Base automatically changed from pure_unary_rpc_1 to samplecode-master December 9, 2020 01:15
@summer-ji-eng summer-ji-eng merged commit 8dea44b into samplecode-master Dec 10, 2020
@summer-ji-eng summer-ji-eng deleted the paged_unary_rpc_2 branch December 10, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 Awaiting requested review from xiaozhenliu-gg5

1 more reviewer

@miraleung miraleung miraleung approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summer-ji-eng @miraleung