lint: Remove non-constant format string in calls

stephenfin · stephenfin · commit 02c2636a8a1e · 2025-05-29T13:14:46.000+01:00
I'm not sure why this was disabled, but undisable it.

Signed-off-by: Stephen Finucane &lt;stephenfin@redhat.com&gt;
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -18,8 +18,6 @@ linters:
       - linters:
           - staticcheck
         text: "SA1019: (x509.EncryptPEMBlock|strings.Title)"
-      - path: (.+)\.go$
-        text: SA1006
     paths:
       - third_party$
       - builtin$
diff --git a/openstack/networking/v2/extensions/security/addressgroups/testing/requests_test.go b/openstack/networking/v2/extensions/security/addressgroups/testing/requests_test.go
@@ -23,7 +23,7 @@ func TestList(t *testing.T) {
 		w.Header().Add("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
 
-		fmt.Fprintf(w, AddressGroupListResponse)
+		fmt.Fprint(w, AddressGroupListResponse)
 	})
 
 	count := 0
@@ -73,7 +73,7 @@ func TestCreate(t *testing.T) {
 		w.Header().Add("Content-Type", "application/json")
 		w.WriteHeader(http.StatusCreated)
 
-		fmt.Fprintf(w, AddressGroupCreateResponse)
+		fmt.Fprint(w, AddressGroupCreateResponse)
 	})
 
 	opts := addressgroups.CreateOpts{
@@ -107,7 +107,7 @@ func TestGet(t *testing.T) {
 		w.Header().Add("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
 
-		fmt.Fprintf(w, AddressGroupGetResponse)
+		fmt.Fprint(w, AddressGroupGetResponse)
 	})
 
 	sr, err := addressgroups.Get(context.TODO(), fake.ServiceClient(fakeServer), "8722e0e0-9cc9-4490-9660-8c9a5732fbb0").Extract()
@@ -134,7 +134,7 @@ func TestUpdate(t *testing.T) {
 			w.Header().Add("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
 
-			fmt.Fprintf(w, AddressGroupUpdateResponse)
+			fmt.Fprint(w, AddressGroupUpdateResponse)
 		})
 
 	name := "ADDR_GP_2"
@@ -168,7 +168,7 @@ func TestAddAddresses(t *testing.T) {
 			w.Header().Add("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
 
-			fmt.Fprintf(w, AddressGroupAddAddressesResponse)
+			fmt.Fprint(w, AddressGroupAddAddressesResponse)
 		})
 
 	opts := addressgroups.UpdateAddressesOpts{
@@ -197,7 +197,7 @@ func TestRemoveAddresses(t *testing.T) {
 			w.Header().Add("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
 
-			fmt.Fprintf(w, AddressGroupRemoveAddressesResponse)
+			fmt.Fprint(w, AddressGroupRemoveAddressesResponse)
 		})
 
 	opts := addressgroups.UpdateAddressesOpts{
