`unsafe.Pointer(nil)` doesn't convert correctly to other pointer types. #1060

nevkontakte · 2021-09-17T15:24:36Z

GopherJS's zero value for unsafe.Pointer is a numeric 0 (I'm guessing for interop with uintptr, but not entirely sure). However, this is incompatible with a pointer interface and causes incorrect behavior when converted into another pointer type:

package main

import (
	"unsafe"
)

func main() {
	var up unsafe.Pointer

	p := (*bool)(up)
	if p != nil {
		println("error: p should be nil")
	}
	println("not nil", *p)
}

By contrast, if up is initialized with unsafe.Pointer((*bool)(nil)), the program works correctly.

The text was updated successfully, but these errors were encountered:

The fix is two-fold: 1. `disableSplice` is initialized with `(*bool)(nil)` to work around gopherjs#1060. 2. Skipped `TestSplicePipePool`, which relies in runtime features GopherJS doesn't support.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`unsafe.Pointer(nil)` doesn't convert correctly to other pointer types. #1060

`unsafe.Pointer(nil)` doesn't convert correctly to other pointer types. #1060

nevkontakte commented Sep 17, 2021

unsafe.Pointer(nil) doesn't convert correctly to other pointer types. #1060

unsafe.Pointer(nil) doesn't convert correctly to other pointer types. #1060

Comments

nevkontakte commented Sep 17, 2021

`unsafe.Pointer(nil)` doesn't convert correctly to other pointer types. #1060

`unsafe.Pointer(nil)` doesn't convert correctly to other pointer types. #1060