internal/poll: fails to build on Windows #688

lifeng1992 · 2017-08-27T19:22:47Z

What version of Go are you using (go version)?

go version go1.9 windows/amd64

What version of GopherJS are you using ?

GopherJS 1.9-1

What did you do?

cat src/hello/main.go

package main

import (
        "github.com/gopherjs/gopherjs/js"
        "fmt"
)

func SayHello(name string) string {
	fmt.Println("Hello", name)
        return "Hello " + name
}

func main() {
        js.Module.Get("exports").Set("SayHello", SayHello)
}

gopherjs build hello/main.go

What did you expect to see?

No errors

What did you see instead?

..\..\..\..\..\..\Go\src\internal\poll\fd_windows.go:367:22: invalid operation: fd.pd (variable of type pollDesc) has no field or method runtimeCtx
..\..\..\..\..\..\Go\src\internal\poll\fd_windows.go:368:22: invalid operation: fd.pd (variable of type pollDesc) has no field or method runtimeCtx
..\..\..\..\..\..\Go\src\internal\poll\fd_windows.go:157:5: invalid operation: o.fd.pd (variable of type pollDesc) has no field or method runtimeCtx

I think the bug is caused by commit 956dce4

The text was updated successfully, but these errors were encountered:

dmitshur · 2017-08-27T20:09:37Z

Thanks a lot for this excellent bug report, @lifeng1992.

It looks like GopherJS 1.9-1 is not working with GOOS=windows. I only tested it on macOS.

In the meantime, can you try a work around of cross compiling for macOS or Linux? E.g.:

GOOS=darwin gopherjs build hello/main.go

I will work on fixing the bug soon.

dmitshur · 2017-08-27T21:28:55Z

I can reproduce locally on macOS:

$ GOOS=windows gopherjs run main.go 
../../../../../../../../../../../usr/local/go/src/internal/poll/fd_windows.go:367:22: invalid operation: fd.pd (variable of type pollDesc) has no field or method runtimeCtx
../../../../../../../../../../../usr/local/go/src/internal/poll/fd_windows.go:368:22: invalid operation: fd.pd (variable of type pollDesc) has no field or method runtimeCtx
../../../../../../../../../../../usr/local/go/src/internal/poll/fd_windows.go:157:5: invalid operation: o.fd.pd (variable of type pollDesc) has no field or method runtimeCtx

myitcv · 2017-08-27T22:02:38Z

@shurcooL presumably we can add a cross compile for Windows to the CI build matrix to help catch these?

dmitshur · 2017-08-27T23:38:03Z

Yes. (It would be an additional workload.)

We can also reconsider the decision of supporting multiple GOOS values instead of having gopherjs always use a fixed one (such as GOOS=linux). I'm still not convinced that the benefits justify the disadvantages (edit: I forgot one of the benefits is being able to use syscall module, that's quite important).

joeblew99 · 2017-09-01T10:17:58Z

fails for me too on win10 too btw.

dmitshur · 2017-09-06T00:12:10Z

I will work on fixing the bug soon.

Okay, I investigated this and posted #693. My original plan to resolve this issue was to make gopherjs always build for the same supported GOOS value. That way, I could fix Windows without actually having to use it.

Unfortunately, that proposal won't work exactly as I imagined it (a 2 line PR), and fixing Windows support is going to be more work.

I can't afford to spend time on supporting Windows now, so I won't be actively working on this.

You can either continue to use GOOS=darwin gopherjs build, etc., for building JavaScript for running in the browser, or use a supported OS (perhaps in a VM). Or maybe someone else will want to work on fixing Windows. Sorry about the inconvenience.

pbrown12303 · 2017-09-25T17:09:09Z

Wow! Is this an official announcement that gopherjs development will not be supported on Windows?

theclapp · 2017-09-25T17:17:41Z

I think it's an announcement that @shurcooL won't be fixing it any time soon.

Is using GOOS=darwin gopherjs [...] problematic? I'm not currently developing on Windows.

pbrown12303 · 2017-09-25T17:34:24Z

I just tried darwin. Though it is supposed to work (according to the documentation) I get compiler errors from gcc_darwin... - looks like some OS functions have marginally different names (e.g. the call does not have an underscore before the name and the provided function does).

dmitshur · 2017-09-25T19:28:34Z

This is a valid issue. I'm not working on it, but anyone else who's interested can.

I get compiler errors from gcc_darwin...

Can you post exact command(s) you ran and the output you got?

pbrown12303 · 2017-09-26T17:21:32Z

Sure. First, the environment variables:

S C:\Users\pbrow> Get-ChildItem Env: | format-list


Name  : ALLUSERSPROFILE
Value : C:\ProgramData

Name  : APPDATA
Value : C:\Users\pbrow\AppData\Roaming

Name  : CGO_ENABLED
Value : 1

Name  : CommonProgramFiles
Value : C:\Program Files\Common Files

Name  : CommonProgramFiles(x86)
Value : C:\Program Files (x86)\Common Files

Name  : CommonProgramW6432
Value : C:\Program Files\Common Files

Name  : COMPUTERNAME
Value : PCBT560

Name  : ComSpec
Value : C:\WINDOWS\system32\cmd.exe

Name  : configsetroot
Value : C:\WINDOWS\ConfigSetRoot

Name  : GOOS
Value : darwin

Name  : GOPATH
Value : C:\GoWorkspace\

Name  : GOROOT
Value : C:\Go\

Name  : HOMEDRIVE
Value : C:

Name  : HOMEPATH
Value : \Users\pbrow

Name  : LOCALAPPDATA
Value : C:\Users\pbrow\AppData\Local

Name  : LOGONSERVER
Value : \\PCBT560

Name  : NUMBER_OF_PROCESSORS
Value : 4

Name  : OneDrive
Value : C:\Users\pbrow\OneDrive

Name  : OS
Value : Windows_NT

Name  : Path
Value : C:\Program Files (x86)\RSA SecurID Token Common;C:\ProgramData\Oracle\Java\javapath;C:\Program Files
        (x86)\Intel\iCLS Client\;C:\Program Files\Intel\iCLS Client\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32
        \Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Intel\Intel(R) Management Engine
        Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files
        (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Intel\Intel(R) Management Engine
        Components\IPT;C:\Program Files\Git\cmd;C:\Software\Qt\5.9.1\mingw53_32;C:\msys64\mingw64\bin;C:\Program
        Files\Intel\WiFi\bin\;C:\Program Files\Common
        Files\Intel\WirelessCommon\;C:\Go\bin;C:\Users\pbrow\AppData\Local\Microsoft\WindowsApps;

Name  : PATHEXT
Value : .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL

Name  : PKG_CONFIG_PATH
Value : C:\msys64\mingw64\lib\pkgconfig

Name  : PROCESSOR_ARCHITECTURE
Value : AMD64

Name  : PROCESSOR_IDENTIFIER
Value : Intel64 Family 6 Model 78 Stepping 3, GenuineIntel

Name  : PROCESSOR_LEVEL
Value : 6

Name  : PROCESSOR_REVISION
Value : 4e03

Name  : ProgramData
Value : C:\ProgramData

Name  : ProgramFiles
Value : C:\Program Files

Name  : ProgramFiles(x86)
Value : C:\Program Files (x86)

Name  : ProgramW6432
Value : C:\Program Files

Name  : PSModulePath
Value : C:\Users\pbrow\Documents\WindowsPowerShell\Modules;C:\Program
        Files\WindowsPowerShell\Modules;C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules

Name  : PUBLIC
Value : C:\Users\Public

Name  : QT_DIR
Value : C:\Software\Qt

Name  : QT_MSYS2
Value : true

Name  : QT_MSYS2_ARCH
Value : amd64

Name  : QT_MSYS2_DIR
Value : C:\msys64

Name  : QT_MSYS2_STATIC
Value : true

Name  : QT_VERSION
Value : 5.9.1

Name  : SESSIONNAME
Value : Console

Name  : SystemDrive
Value : C:

Name  : SystemRoot
Value : C:\WINDOWS

Name  : TEMP
Value : C:\Users\pbrow\AppData\Local\Temp

Name  : TMP
Value : C:\Users\pbrow\AppData\Local\Temp

Name  : USERDOMAIN
Value : PCBT560

Name  : USERDOMAIN_ROAMINGPROFILE
Value : PCBT560

Name  : USERNAME
Value : pbrow

Name  : USERPROFILE
Value : C:\Users\pbrow

Name  : windir
Value : C:\WINDOWS

Now the build results after creating the GOOS=darwin environment variable and cleaning my project

************  Building Go project: activeCRL  ************
  with GOPATH: C:\GoWorkspace\
>> Running: C:\Go\bin\go.exe install -v -gcflags " -N -l" github.com/pbrown12303/activeCRL/activeCRL/...
runtime/cgo
# runtime/cgo
gcc_darwin_amd64.c: In function '_cgo_sys_thread_start':
gcc_darwin_amd64.c:86:2: error: unknown type name 'sigset_t'; did you mean '_sigset_t'?
  sigset_t ign, oset;
  ^~~~~~~~
  _sigset_t
gcc_darwin_amd64.c:91:2: error: implicit declaration of function 'sigfillset' [-Werror=implicit-function-declaration]
  sigfillset(&ign);
  ^~~~~~~~~~
gcc_darwin_amd64.c:86:16: error: unused variable 'oset' [-Werror=unused-variable]
  sigset_t ign, oset;
                ^~~~
cc1.exe: all warnings being treated as errors
   ^^^ Terminated, exit code: 2 ^^^
************  Build terminated.  ************

pbrown12303 · 2017-09-26T20:08:31Z

Some progress. I had CGO=1. When I removed that and set GOARCH=amd64, everything compiles. However, the tests will not execute. I get:

************  Building Go project: activeCRL  ************
  with GOPATH: C:\GoWorkspace\
>> Running: C:\Go\bin\go.exe test -v -gcflags "-N -l" github.com/pbrown12303/activeCRL/activeCRL/...
fork/exec C:\Users\pbrow\AppData\Local\Temp\go-build754112998\github.com\pbrown12303\activeCRL\activeCRL\core\_test\core.test: %1 is not a valid Win32 application.
FAIL	github.com/pbrown12303/activeCRL/activeCRL/core	0.011s
fork/exec C:\Users\pbrow\AppData\Local\Temp\go-build754112998\github.com\pbrown12303\activeCRL\activeCRL\coreFunctions\_test\coreFunctions.test: %1 is not a valid Win32 application.
FAIL	github.com/pbrown12303/activeCRL/activeCRL/coreFunctions	0.012s
fork/exec C:\Users\pbrow\AppData\Local\Temp\go-build754112998\github.com\pbrown12303\activeCRL\activeCRL\coreFunctionsUpdate\_test\coreFunctionsUpdate.test: %1 is not a valid Win32 application.
FAIL	github.com/pbrown12303/activeCRL/activeCRL/coreFunctionsUpdate	0.134s
fork/exec C:\Users\pbrow\AppData\Local\Temp\go-build754112998\github.com\pbrown12303\activeCRL\activeCRL\coreUpdate\_test\coreUpdate.test: %1 is not a valid Win32 application.
FAIL	github.com/pbrown12303/activeCRL/activeCRL/coreUpdate	0.014s
?   	github.com/pbrown12303/activeCRL/activeCRL/crlEditor	[no test files]
   ^^^ Terminated, exit code: 1 ^^^
************  Build terminated.  ************

dmitshur · 2017-09-26T20:30:10Z

C:\Go\bin\go.exe install

Are you running go install? This issue is about gopherjs.

Let me clarify, what I said earlier is that you should use GOOS=darwin with gopherjs binary, not with go binary.

You should install gopherjs normally, without any kind of cross compilation.

pbrown12303 · 2017-09-26T20:32:51Z

I did go install a long time ago. I'm developing an application. So wherever I am using the go binary at present I should be using the gopherjs binary - even for .go files that have nothing to do with gopherjs?

…

-- PCB

_______________________________________________________________ Paul C. Brown Paul C. Brown Consulting LLC - *Specializing in IT Architecture and Strategy* "Total architecture is not a choice - it is a concession to reality." Email: pbrow <[email protected]>[email protected] Mobile: 518-424-5360 Architecture Books:

-- Succeeding With SOA: Realizing Business Value Through Total Architecture <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Implementing SOA: Total Architecture In Practice <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- TIBCO Architecture Fundamentals <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Architecting Composite Applications and Services with TIBCO <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Architecting Complex-Event Processing Solutions with TIBCO <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb> The SOA Manifesto: soa-manifesto.or <http://soa-manifesto.org/>g

______________________________________________________________

On Tue, Sep 26, 2017 at 4:30 PM, Dmitri Shuralyov ***@***.***> wrote: C:\Go\bin\go.exe install Are you running go install? This issue is about gopherjs. Let me clarify, what I said earlier is that you should use GOOS=darwin with gopherjs binary, not with go binary. You should install gopherjs normally, without any kind of cross compilation. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#688 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARw4jCpEp9nkcmwbf2_hwd7Qi9IagnI4ks5smV7bgaJpZM4PD5Dl> .

dmitshur · 2017-09-26T21:28:31Z

This issue is about gopherjs compiler not working on Windows unless you specify GOOS=darwin. Since you're posting here about it, I thought that was what we were talking about.

If you're compiling things not related to GopherJS, then this issue and discussion in it is not relevant.

pbrown12303 · 2017-09-27T14:20:30Z

I think it is relevant. The environment variable affects both normal go compiles and gopherjs. You're telling me it's OK to have an environment variable setting that has to be different (i.e. changed) every time you switch from go work to gopherjs work? Remember, we got here because the GOOS=windows is broken for gopherjs.

dmitshur · 2017-09-27T18:34:22Z

Ok, I think I understand your issue now.

You're setting the GOOS=darwin environment variable globally, which then fixes GopherJS for you, but breaks normal Go. If you don't set it, then normal Go works, but GopherJS doesn't. Is that the issue you're having?

Setting the GOOS environment variable globally is not an ideal approach, when you run into different commands where you want to use different environment variables. I don't use Windows actively, but the last time I did, it was possible to use a bash-like shell where you could prepend environment variable assignments before executing a binary to set environment variables for that process only, like so:

$ go build
$ GOOS=darwin gopherjs build

Doing that would be my recommendation. Hopefully that helps.

pbrown12303 · 2017-09-28T12:40:36Z

Yes, that's the issue. Your suggestion will work, but let's recognize that it is a work-around. It would be nice to fix the two underlying issues so that environments can be consistent across go and gopherjs. To recap, these are: - gopherjs does not execute correctly when GOOS=windows - go does not execute correctly when GOOS=darwin

…

-- PCB

_______________________________________________________________ Paul C. Brown Paul C. Brown Consulting LLC - *Specializing in IT Architecture and Strategy* "Total architecture is not a choice - it is a concession to reality." Email: pbrow <[email protected]>[email protected] Mobile: 518-424-5360 Architecture Books:

-- Succeeding With SOA: Realizing Business Value Through Total Architecture <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Implementing SOA: Total Architecture In Practice <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- TIBCO Architecture Fundamentals <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Architecting Composite Applications and Services with TIBCO <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb>

-- Architecting Complex-Event Processing Solutions with TIBCO <http://www.informit.com/authors/bio.aspx?a=53cdb713-432d-4e63-a5b1-3a9ee6fedbeb> The SOA Manifesto: soa-manifesto.or <http://soa-manifesto.org/>g

______________________________________________________________

On Wed, Sep 27, 2017 at 2:34 PM, Dmitri Shuralyov ***@***.***> wrote: Ok, I think I understand your issue now. You're setting the GOOS=darwin environment variable globally, which then fixes GopherJS for you, but breaks normal Go. If you don't set it, then normal Go works, but GopherJS doesn't. Is that the issue you're having? Setting the GOOS environment variable globally is not an ideal approach, when you run into different commands where you want to use different environment variables. I don't use Windows actively, but the last time I did, it was possible to use a bash-like shell where you could prepend environment variable assignments before executing a binary to set environment variables for that process only, like so: $ go build $ GOOS=darwin gopherjs build Doing that would be my recommendation. Hopefully that helps. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#688 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARw4jPIfpKUZ9vqxVGigJ5j72l6KcykNks5smpU3gaJpZM4PD5Dl> .

dmitshur · 2017-09-28T16:45:48Z

Your suggestion will work

Good to hear.

but let's recognize that it is a work-around.

It certainly is. That's why this issue is open and has bug, NeedsFix labels.

It would be nice to fix the two underlying issues so that environments can be consistent across go and gopherjs.

It will be nice to fix this issue, but, that doesn't mean the environments can be consistent. GOOS and GOARCH environment variables are effectively arguments to the Go compiler. The GopherJS compiler also uses the GOOS environment variable in the same way. You can read more about it at https://golang.org/doc/install/source#environment.

So, you're expected to set GOOS or GOARCH as needed depending on what target you want to compile for (i.e., cross-compilation). Also see https://medium.com/@rakyll/go-1-5-cross-compilation-488092ba44ec for more information on cross-compilation.

pbrown12303 · 2017-09-30T14:46:05Z

Sounds like it would be useful to have some gopherjs-specific environment variables that would override (if necessary) the go-specific variables, e.g. GOPHERJSOS.

Add instructions for what people should do when building with GopherJS on unsupported platforms. Code generation works completely fine, but syscalls (e.g., for gopherjs run) will only work on supported platforms. Previously, this information was only in issues, people's heads, commit messages, etc. It should be documented in README to provide clarity. Rename "OS X" to "macOS", the current name of that operating system. Rearrange sections to place more relevant information first. Mention Linux before macOS consistently. Linux is placed first because it's open source and more freely available than the proprietary macOS, so it's easier to recommend it as an alternative. Resolves #770. Updates #776. Updates #688.

dmitshur added bug NeedsFix labels Aug 27, 2017

dmitshur self-assigned this Aug 27, 2017

200sc mentioned this issue Aug 31, 2017

Browser support through GopherJS oakmound/oak#13

Closed

dmitshur mentioned this issue Sep 5, 2017

proposal: Limit support to one GOOS value (primarily for stdlib). #693

Closed

dmitshur removed their assignment Sep 6, 2017

dmitshur changed the title ~~invalid operation: fd.pd (variable of type pollDesc) has no field or method runtimeCtx~~ internal/poll: fails to build on Windows Sep 6, 2017

hajimehoshi mentioned this issue Sep 6, 2017

Verify Ebiten works on Edge hajimehoshi/ebiten#71

Closed

dmitshur mentioned this issue Sep 17, 2017

Helloworld does not compiled #703

Closed

dmitshur mentioned this issue Oct 22, 2017

Gopherjs 1.9-1 and go 1.9.1 on windows gopherjs/gopherpen#9

Closed

githubfanster mentioned this issue Jan 16, 2018

gopherjs build problem in 64bit windows 10 EngineerKamesh/igb#1

Closed

dmitshur mentioned this issue Mar 16, 2018

README: Document supported GOOS values. #777

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/poll: fails to build on Windows #688

internal/poll: fails to build on Windows #688

lifeng1992 commented Aug 27, 2017

dmitshur commented Aug 27, 2017 •

edited

Loading

dmitshur commented Aug 27, 2017

myitcv commented Aug 27, 2017

dmitshur commented Aug 27, 2017 •

edited

Loading

joeblew99 commented Sep 1, 2017

dmitshur commented Sep 6, 2017 •

edited

Loading

pbrown12303 commented Sep 25, 2017

theclapp commented Sep 25, 2017

pbrown12303 commented Sep 25, 2017

dmitshur commented Sep 25, 2017

pbrown12303 commented Sep 26, 2017

pbrown12303 commented Sep 26, 2017

dmitshur commented Sep 26, 2017

pbrown12303 commented Sep 26, 2017 via email •

edited

Loading

dmitshur commented Sep 26, 2017

pbrown12303 commented Sep 27, 2017

dmitshur commented Sep 27, 2017

pbrown12303 commented Sep 28, 2017 via email

dmitshur commented Sep 28, 2017

pbrown12303 commented Sep 30, 2017

internal/poll: fails to build on Windows #688

internal/poll: fails to build on Windows #688

Comments

lifeng1992 commented Aug 27, 2017

What version of Go are you using (go version)?

What version of GopherJS are you using ?

What did you do?

What did you expect to see?

What did you see instead?

dmitshur commented Aug 27, 2017 • edited Loading

dmitshur commented Aug 27, 2017

myitcv commented Aug 27, 2017

dmitshur commented Aug 27, 2017 • edited Loading

joeblew99 commented Sep 1, 2017

dmitshur commented Sep 6, 2017 • edited Loading

pbrown12303 commented Sep 25, 2017

theclapp commented Sep 25, 2017

pbrown12303 commented Sep 25, 2017

dmitshur commented Sep 25, 2017

pbrown12303 commented Sep 26, 2017

pbrown12303 commented Sep 26, 2017

dmitshur commented Sep 26, 2017

pbrown12303 commented Sep 26, 2017 via email • edited Loading

dmitshur commented Sep 26, 2017

pbrown12303 commented Sep 27, 2017

dmitshur commented Sep 27, 2017

pbrown12303 commented Sep 28, 2017 via email

dmitshur commented Sep 28, 2017

pbrown12303 commented Sep 30, 2017

dmitshur commented Aug 27, 2017 •

edited

Loading

dmitshur commented Aug 27, 2017 •

edited

Loading

dmitshur commented Sep 6, 2017 •

edited

Loading

pbrown12303 commented Sep 26, 2017 via email •

edited

Loading