Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI is broken #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Jan 31, 2021 · 3 comments · Fixed by #988
Closed

CI is broken #987

dmitshur opened this issue Jan 31, 2021 · 3 comments · Fixed by #988
Assignees
@dmitshur
Labels
NeedsFix

Comments

@dmitshur
Copy link
Member

I've tried making a trivial commit just now that should pass CI, 2b03b95, but it failed.

There was a problem with this step in circle.yml:

cd node-syscall && node-gyp rebuild && mkdir -p ~/.node_libraries && cp build/Release/syscall.node ~/.node_libraries/syscall.node

gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info find Python using Python version 2.7.17 found at "/usr/bin/python"
gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: ENOENT: no such file or directory, mkdir '/root/.cache/node-gyp/10.0.0'
gyp ERR! System Linux 4.15.0-1092-aws
gyp ERR! command "/root/.nvm/versions/node/v10.0.0/bin/node" "/root/.nvm/versions/node/v10.0.0/bin/node-gyp" "rebuild"
gyp ERR! cwd /root/go/src/github.com/gopherjs/gopherjs/node-syscall
gyp ERR! node -v v10.0.0
gyp ERR! node-gyp -v v7.1.2
gyp ERR! not ok 


Exited with code exit status 1
@nevkontakte
Copy link
Member

I haven't looked closely into this, but maybe goplusjs/gopherjs@2452510#diff-21b1fe66043572c76c549a4fc5f186e9a69c330b186fc91116b9b70a4d047902 from @visualfc's fork is the fix.

@dmitshur
Copy link
Member Author

dmitshur commented Jan 31, 2021 •
edited
Loading

Thanks for the suggestion. That doesn't appear to be it, because we've made that change even earlier in PR #938.

Perhaps goplusjs/gopherjs@a293d52#diff-21b1fe66043572c76c549a4fc5f186e9a69c330b186fc91116b9b70a4d047902 is relevant.

@dmitshur
Copy link
Member Author

I've investigated this and confirmed that the problem is that the latest version of node-gyp, v7.1.2 at this time, no longer works with Node version v10.0.0 selected in circle.yml. Things start to work as before if [email protected] is installed.

To fix this, we either need to update Node to a newer version that node-gyp v7 requires (Node v14.13.1 fixed the immediate error in my brief testing), or ensure the older node-gyp version is selected. I'll probably take the shorter path of downgrading node-gyp for now, and upgrading both of them can be a future enhancement.

dmitshur added a commit that referenced this issue Jan 31, 2021
@dmitshur
CI: specify fixed version of node-gyp
4415183 
The latest version of node-gyp (v7.1.2 at this time) is not compatible
with Node v10.0.0 that circle.yml installs. Go back to a known working
version of node-gyp to get a working CI.

Fixes #987.
@dmitshur dmitshur self-assigned this Jan 31, 2021
@dmitshur dmitshur mentioned this issue Jan 31, 2021
Merged
dmitshur added a commit that referenced this issue Feb 2, 2021
@dmitshur
CI: fix breakage and update minor Go version
bed99a8 
The latest version of node-gyp (v7.1.2 at this time) is not compatible
with Node v10.0.0 that circle.yml installs. Go back to a known working
version of node-gyp to get a working CI.

Update the CI script to test against Go 1.12.17¹,
the latest minor release in the Go 1.12.x series.

¹ https://golang.org/doc/devel/release.html#go1.12.minor

Updates #894.
Fixes #987.

GitHub-Pull-Request: #988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
NeedsFix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: fix breakage and update minor Go version gopherjs/gopherjs
2 participants
@nevkontakte @dmitshur