Eliminate false positive for new(js.object)

flimzy · flimzy · commit a780c237aa82 · 2023-08-04T13:52:24.000+02:00
diff --git a/analysis/passes/jsobjectptr/jsobjectptr.go b/analysis/passes/jsobjectptr/jsobjectptr.go
@@ -35,7 +35,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
 		parent := stack[len(stack)-2]
 		switch pt := parent.(type) {
 		case *ast.StarExpr:
-			// Fall through
+			return true
 		case *ast.CallExpr:
 			fun, ok := pt.Fun.(*ast.Ident)
 			if !ok {
diff --git a/analysis/passes/jsobjectptr/testdata/src/jsobjectptr/jsobjectptr.go b/analysis/passes/jsobjectptr/testdata/src/jsobjectptr/jsobjectptr.go
@@ -22,6 +22,7 @@ var (
 	_ struct{ x js.Object }     // want "js.Object must always be a pointer"
 	_ = struct{ x js.Object }{} // want "js.Object must always be a pointer"
 	_ = new(js.Object)
+	_ *js.Object
 )
 
 func _(js.Object) {} // want "js.Object must always be a pointer"

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ var (`
`22`	`22`	`_ struct{ x js.Object } // want "js.Object must always be a pointer"`
`23`	`23`	`_ = struct{ x js.Object }{} // want "js.Object must always be a pointer"`
`24`	`24`	`_ = new(js.Object)`
	`25`	`+ _ *js.Object`
`25`	`26`	`)`
`26`	`27`
`27`	`28`	`func _(js.Object) {} // want "js.Object must always be a pointer"`