Fix regex used to extract attribute name in element picker

gorhill · gorhill · commit 9a94ba0a226f · 2021-03-31T12:21:29.000-04:00
Related feedback: - https://www.reddit.com/r/uBlockOrigin/comments/mh2ctv/
diff --git a/src/js/epicker-ui.js b/src/js/epicker-ui.js
@@ -252,7 +252,7 @@ const cosmeticCandidatesFromFilterChoice = function(filterChoice) {
             }
             // Remove attribute values.
             if ( (specificity & 0b0010) === 0 ) {
-                const match = /^\[([^^=]+)\^?=.+\]$/.exec(filter);
+                const match = /^\[([^^*$=]+)[\^*$]?=.+\]$/.exec(filter);
                 if ( match !== null ) {
                     filter = `[${match[1]}]`;
                 }

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ const cosmeticCandidatesFromFilterChoice = function(filterChoice) {`
`252`	`252`	`}`
`253`	`253`	`// Remove attribute values.`
`254`	`254`	`if ( (specificity & 0b0010) === 0 ) {`
`255`		`- const match = /^\[([^^=]+)\^?=.+\]$/.exec(filter);`
	`255`	`+ const match = /^\[([^^$=]+)[\^$]?=.+\]$/.exec(filter);`
`256`	`256`	`if ( match !== null ) {`
`257`	`257`	filter = `[${match[1]}]`;
`258`	`258`	`}`