Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zeileis
Copy link
Collaborator

@zeileis zeileis commented May 15, 2025

Grant, today I played a bit around with altdoc and tweaked the tinyplot page a bit. (After meeting Etienne who is currently visiting Innsbruck.) I tried a few improvements which I included in this PR. Maybe you want to check them out and see what you like and what you don't like. Feel free to reject the entire PR if you prefer the current version, that's perfectly fine as well.

  • I added a custom.scss for the cosmo theme. This uses the teal, pink, and almost-black colors from the hex sticker. Teal is used for the navbar background, pink for links and highlighting, almost-black for the text.
  • The picture on the canvas of the hex sticker is used as the favicon.
  • The navigation is moved from the sidebar to the navbar. As mentioned in Flatter sidebar on the website #316 the sidebar navigation is a bit inconvenient on mobile devices. The sidebar is only kept for navigating inside the reference.

@grantmcdermott
Copy link
Owner

This is great, thanks. I'll take a look when I get a chance this evening.

Do you mind adding some screenshots to your OP in the meantime, though?

@zeileis
Copy link
Collaborator Author

zeileis commented May 15, 2025

Landing page without sidebar:

Screenshot from landing page without sidebar

Reference page with sidebar:

Screenshot from reference page with sidebar

Hamburger menu on emulated mobile device:

Screenshot from hamburger menu on emulated mobile device

@grantmcdermott
Copy link
Owner

grantmcdermott commented May 16, 2025

I just rendered and previewed everything locally. I really like the proposed changes; it feels like a clear improvement on top of what we already have.

I'm tempted to merge as-is, but two very minor thoughts first:

  • While the highlighted "pink" colour looks good against the white background, it's a little garish for my tastes against the teal background. Is there perhaps a softer option that we could try? This is not a strongly held opinion, and you're the color expert, so feel free to go with your preferred aesthetic.
  • One collateral benefit of moving everything to the navbar is that we "recover" a menu level. Along those lines, I can see that you already added a "Main functions" entry in the References section and I like this idea. Similarly, I wonder whether it makes sense to create a "Types" (or "Plot types") menu entry where can nest "Shapes", "Visualizations", and co. under? (Note: This is what we had originally, but we dropped it to avoid too-deep menu nesting... which may be moot now that the navbar has given us one menu level back.)

@grantmcdermott
Copy link
Owner

I had a sec, so actioned the second bullet point above. We can revisit the first later (maybe), but happy to merge now. These changes look fantastic, thanks @zeileis!

@grantmcdermott grantmcdermott merged commit 83650ab into main May 16, 2025
3 checks passed
@zeileis
Copy link
Collaborator Author

zeileis commented May 17, 2025

  • I'll have a look at a better way to highlight the selected navbar link. Either by using a lighter color or by using a different type of highlighting. But I need some time to play with the CSS here.
  • For my personal taste, the value added by the additional hierarchy level doesn't justify the additional click. So I would prefer the flatter menu. (Feel free to disagree, of course.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants