Support manual breaks (`x/yaxb`) #400

grantmcdermott · 2025-05-18T05:28:23Z

Closes #366

Operationalised through the new xaxb and yaxb args. Should play nicely with axis limits and the panel grid, as well as any formatting adjustments applied through x/yaxl.

pkgload::load_all("~/Documents/Projects/tinyplot")
#> ℹ Loading tinyplot

plt(
  mpg ~ hp | am, mtcars, facet = "by",
  xaxb = c(80, 160, 240, 320),
  yaxb = c(12, 16, 24, 40),
  grid = TRUE
)

plt(
  count ~ spray,
  data = InsectSprays,
  xaxb = c("A", "C", "F"), xaxl = tolower, 
  yaxb = c(10, 30), yaxl = "$"
)

^{Created on 2025-05-17 with reprex v2.1.1}

grantmcdermott · 2025-05-18T05:42:45Z

@vincentarelbundock I think that this covers the use case/need that you had in mind. Would you mind reviewing or taking a quick look when you get a chance?

R/lim.R

vincentarelbundock · 2025-05-18T10:07:32Z

Thanks, this is exactly what I needed. A really important feature! (sorry I didn't get to it in time).

The only comment I have is about whether we should give xaxb or xlim priority when both are specified and enter in conflict. My gut says that xlim should have priority since it is a base setting, but I don't feel super strongly about it.

Rest looks great.

zeileis · 2025-05-18T11:10:40Z

Nice! We also need to incorporate that into type_spineplot(). The xaxb would be the default for breaks unless the latter is specified by the user. The yaxb should be taken to indicate which of the y-axis categories should be labeled or not.

grantmcdermott · 2025-05-18T20:27:55Z

Nice! We also need to incorporate that into type_spineplot(). The xaxb would be the default for breaks unless the latter is specified by the user. The yaxb should be taken to indicate which of the y-axis categories should be labeled or not.

Good catch. So, internally we would just need to make sure that (say) xaxb is transferred to breaks.

Question, though: Should we hide these type_spineplot()-specific arguments from the user then and rather enforce that they go through the top-level x/yaxb arguments for consistency? I know it would be a breaking change, but I think we should favour a single (common) top-level approach for doing something if possible. Alternatively, if we keep them, which takes precedence if the user specifies both (say) xaxb and type_spineplot(breaks = ...)? (Edit: Ignore and see below.)

grantmcdermott · 2025-05-19T01:03:30Z

Question, though: Should we hide these type_spineplot()-specific arguments from the user then and rather enforce that they go through the top-level x/yaxb arguments for consistency? I know it would be a breaking change, but I think we should favour a single (common) top-level approach for doing something if possible. Alternatively, if we keep them, which takes precedence if the user specifies both (say) xaxb and type_spineplot(breaks = ...)?

Sorry, ignore what I was saying above. I was quickly typing on my phone while I was out and hadn't read your comments properly or thought about it clearly. I now recall that type_spineplot(breaks = ...) accepts a single number (analogous to histograms), whereas xaxb specifies the exact break points. As such, I agree with your comment @zeileis that "xaxb would be the default for breaks unless the latter is specified by the user."

zeileis · 2025-05-19T01:27:54Z

Like in hist(), the breaks can be both, either the number of breaks or the location of the breaks. So if xaxb is specified and breaks is not (i.e., NULL), breaks = xaxb can be used.

- spineplot integration

grantmcdermott · 2025-05-19T04:48:53Z

Okay, I think we're good to go. Thanks both for the comments and suggestions ;-)

zeileis · 2025-05-19T06:45:28Z

Thanks!

…sticker (#411) * Handle xmin/xmax/ymin/ymax along with model.frame (#403) * handle xmin/xmax/ymin/ymax along with model.frame * turn facet into a formula if it does not evaluate successfully * document min/max processing in NEWS and ?tinyplot * typo * use formula-based syntax for pointrange/errorbar * run devtools::document * Support manual breaks (`x/yaxb`) (#400) * support xaxb/yaxb * smol example * add test * news * vincent comment * fix spineplot ylevels bug (#404) * achim's comment - spineplot integration * minor doc fix * news * Add warnings and documentation for adding to faceted plots (#407) * only save pars when add == FALSE * Positron warning * document limitations * typos * feat: Added 'tinyplot' writing (font Roboto Condensed) to top navigation, added background (dots) inspired by the logo. In addition, vectorized the logo and added the original (Inkscape SVG) as well as a sticker version (plain SVG) in the new 'inst' folder. --------- Co-authored-by: Achim Zeileis <[email protected]> Co-authored-by: Grant McDermott <[email protected]>

* cosmo theme with custom colors based on teal/pink/black from hex sticker * set favicon (based on hex canvas), image, site-url * use navbar for main navigation and sidebar only in reference * forgot to add favicon.png * reorganize reference in navbar+sidebar, use ALTDOC_* variables which are available * nest plot types * use white instead of pink in navbar, add border-bottom for hovered/selected links * add mcanouil/iconify extension for bsky icon * streamline left navbar (collapse Articles and About), add bsky and mastodon to right navbar * move hex sticker out of h1 title so that it isn't duplicated in the toc; some further minor tweaks in links/badges * Updated top navigation design (text logo + background), added logo + sticker (#411) * Handle xmin/xmax/ymin/ymax along with model.frame (#403) * handle xmin/xmax/ymin/ymax along with model.frame * turn facet into a formula if it does not evaluate successfully * document min/max processing in NEWS and ?tinyplot * typo * use formula-based syntax for pointrange/errorbar * run devtools::document * Support manual breaks (`x/yaxb`) (#400) * support xaxb/yaxb * smol example * add test * news * vincent comment * fix spineplot ylevels bug (#404) * achim's comment - spineplot integration * minor doc fix * news * Add warnings and documentation for adding to faceted plots (#407) * only save pars when add == FALSE * Positron warning * document limitations * typos * feat: Added 'tinyplot' writing (font Roboto Condensed) to top navigation, added background (dots) inspired by the logo. In addition, vectorized the logo and added the original (Inkscape SVG) as well as a sticker version (plain SVG) in the new 'inst' folder. --------- Co-authored-by: Achim Zeileis <[email protected]> Co-authored-by: Grant McDermott <[email protected]> * switch order of NEWS and Citation * increase depends to R 4.1.0 due function shorthand (would be added by R CMD build with a warning) * add CITATION file, currently just based on package DESCRIPTION but using the CRAN DOI (rather than another URL) * Include improved version of logo in web package - altdoc page includes both logo.svg (vector graphic) and logo.png (500x578) - zoomed-in favicon in higher resolution (500x500) - README uses online logo from grantmcdermott.com (works only after first publication) - drop low-resolution version of old logo from man/figures/ --------- Co-authored-by: Grant McDermott <[email protected]> Co-authored-by: Reto Stauffer <[email protected]>

grantmcdermott added 4 commits May 17, 2025 22:06

support xaxb/yaxb

6d1d2ce

smol example

8596acf

add test

8308ce6

news

92b77d3

vincentarelbundock reviewed May 18, 2025

View reviewed changes

R/lim.R Outdated Show resolved Hide resolved

vincent comment

49ab58c

grantmcdermott mentioned this pull request May 19, 2025

Spineplot: ylevels not working properly #404

Closed

grantmcdermott added 4 commits May 18, 2025 20:34

fix spineplot ylevels bug (#404)

6e61296

achim's comment

54a71bd

- spineplot integration

minor doc fix

144e258

news

7810040

grantmcdermott merged commit d03a30a into main May 19, 2025
3 checks passed

grantmcdermott deleted the xaxb branch May 19, 2025 04:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support manual breaks (`x/yaxb`) #400

Support manual breaks (`x/yaxb`) #400

Uh oh!

grantmcdermott commented May 18, 2025

Uh oh!

grantmcdermott commented May 18, 2025

Uh oh!

Uh oh!

vincentarelbundock commented May 18, 2025

Uh oh!

zeileis commented May 18, 2025

Uh oh!

grantmcdermott commented May 18, 2025 •

edited

Loading

Uh oh!

grantmcdermott commented May 19, 2025 •

edited

Loading

Uh oh!

zeileis commented May 19, 2025

Uh oh!

grantmcdermott commented May 19, 2025

Uh oh!

Uh oh!

zeileis commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Support manual breaks (x/yaxb) #400

Support manual breaks (x/yaxb) #400

Uh oh!

Conversation

grantmcdermott commented May 18, 2025

Uh oh!

grantmcdermott commented May 18, 2025

Uh oh!

Uh oh!

vincentarelbundock commented May 18, 2025

Uh oh!

zeileis commented May 18, 2025

Uh oh!

grantmcdermott commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grantmcdermott commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeileis commented May 19, 2025

Uh oh!

grantmcdermott commented May 19, 2025

Uh oh!

Uh oh!

zeileis commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Support manual breaks (`x/yaxb`) #400

Support manual breaks (`x/yaxb`) #400

grantmcdermott commented May 18, 2025 •

edited

Loading

grantmcdermott commented May 19, 2025 •

edited

Loading