Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ResultPath: Check object type before casting to int #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 2 commits into from
Dec 4, 2024
Merged

ResultPath: Check object type before casting to int #3765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4f0e35
Check object type before casting to int
alex-cova Dec 3, 2024
cf70265
ResultPathTest: Check object type before casting to int
alex-cova Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/graphql/execution/ResultPath.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,10 @@ public static ResultPath fromList(List<?> objects) {
for (Object object : objects) {
if (object instanceof String) {
path = path.segment(((String) object));
} else {
} else if (object instanceof Integer) {
path = path.segment((int) object);
} else if (object != null) {
path = path.segment(object.toString());
}
}
return path;
Expand Down
7 changes: 7 additions & 0 deletions src/test/groovy/graphql/execution/ResultPathTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,13 @@ class ResultPathTest extends Specification {
path.toList() == ["a", "b"]
}

def "pass any other object than string or int"(){
when:
ResultPath.fromList(["a", "b", true])
Copy link
Member

@bbakerman bbakerman Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the graphql-java code itself would never use anything but a String or Integer - but I am happy to have this be more robust


then:
notThrown(ClassCastException)
}

def "can append paths"() {
when:
Expand Down
Loading