Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add more performance tests for overlapping fields validation #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 1 commit into from
Feb 23, 2025
Merged

add more performance tests for overlapping fields validation #3832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 161 additions & 3 deletions src/test/java/performance/OverlappingFieldValidationPerformance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
Expand All @@ -38,15 +39,42 @@
@Fork(3)
public class OverlappingFieldValidationPerformance {


static String schemaSdl = " type Query { viewer: Viewer } interface Abstract { field: Abstract leaf: Int } interface Abstract1 { field: Abstract leaf: Int } interface Abstract2 { field: Abstract leaf: Int }" +
" type Concrete1 implements Abstract1{ field: Abstract leaf: Int} " +
"type Concrete2 implements Abstract2{ field: Abstract leaf: Int} " +
"type Viewer { xingId: XingId } type XingId { firstName: String! lastName: String! }";

@State(Scope.Benchmark)
public static class MyState {

GraphQLSchema schema;
GraphQLSchema schema2;
Document document;

@Param({"2", "10", "100"})
int size;

Document overlapFrag;
Document overlapNoFrag;
Document noOverlapFrag;
Document noOverlapNoFrag;
Document repeatedFields;
Document deepAbstractConcrete;

@Setup
public void setup() {
try {
overlapFrag = makeQuery(size, true, true);
overlapNoFrag = makeQuery(size, true, false);
noOverlapFrag = makeQuery(size, false, true);
noOverlapNoFrag = makeQuery(size, false, false);
repeatedFields = makeRepeatedFieldsQuery(size);
deepAbstractConcrete = makeDeepAbstractConcreteQuery(size);


schema2 = SchemaGenerator.createdMockedSchema(schemaSdl);

String schemaString = PerformanceTestingUtils.loadResource("large-schema-4.graphqls");
String query = PerformanceTestingUtils.loadResource("large-schema-4-query.graphql");
schema = SchemaGenerator.createdMockedSchema(schemaString);
Expand All @@ -64,14 +92,58 @@ public void setup() {

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void overlappingFieldValidationAbgTime(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema, myState.document));
blackhole.consume(validateQuery(myState.schema2, myState.document));
}

@Benchmark
@OutputTimeUnit(TimeUnit.SECONDS)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void overlappingFieldValidationThroughput(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema, myState.document));
blackhole.consume(validateQuery(myState.schema2, myState.document));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkRepeatedFields(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.repeatedFields));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkOverlapFrag(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.overlapFrag));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkOverlapNoFrag(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.overlapNoFrag));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkNoOverlapFrag(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.noOverlapFrag));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkNoOverlapNoFrag(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.noOverlapNoFrag));
}

@Benchmark
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public void benchmarkDeepAbstractConcrete(MyState myState, Blackhole blackhole) {
blackhole.consume(validateQuery(myState.schema2, myState.deepAbstractConcrete));
}

private List<ValidationError> validateQuery(GraphQLSchema schema, Document document) {
Expand All @@ -83,4 +155,90 @@ private List<ValidationError> validateQuery(GraphQLSchema schema, Document docum
languageTraversal.traverse(document, new RulesVisitor(validationContext, Collections.singletonList(overlappingFieldsCanBeMerged)));
return errorCollector.getErrors();
}


private static Document makeQuery(int size, boolean overlapping, boolean fragments) {
if (fragments) {
return makeQueryWithFragments(size, overlapping);
} else {
return makeQueryWithoutFragments(size, overlapping);
}
}

private static Document makeRepeatedFieldsQuery(int size) {
StringBuilder b = new StringBuilder();

b.append(" query testQuery { viewer { xingId {");

b.append("firstName\n".repeat(Math.max(0, size)));

b.append("} } }");

return Parser.parse(b.toString());
}


private static Document makeQueryWithFragments(int size, boolean overlapping) {
StringBuilder b = new StringBuilder();

for (int i = 1; i <= size; i++) {
if (overlapping) {
b.append(" fragment mergeIdenticalFields" + i + " on Query {viewer { xingId { firstName lastName }}}");
} else {
b.append("fragment mergeIdenticalFields" + i + " on Query {viewer" + i + " { xingId" + i + " { firstName" + i + " lastName" + i + " } }}");
}

b.append("\n\n");
}

b.append("query testQuery {");
for (int i = 1; i <= size; i++) {
b.append("...mergeIdenticalFields" + i + "\n");
}
b.append("}");
return Parser.parse(b.toString());
}

private static Document makeQueryWithoutFragments(int size, boolean overlapping) {
StringBuilder b = new StringBuilder();

b.append("query testQuery {");

for (int i = 1; i <= size; i++) {
if (overlapping) {
b.append(" viewer { xingId { firstName } } ");
} else {
b.append(" viewer" + i + " { xingId" + i + " { firstName" + i + " } } ");
}

b.append("\n\n");
}

b.append("}");

return Parser.parse(b.toString());
}

private static Document makeDeepAbstractConcreteQuery(int depth) {
StringBuilder q = new StringBuilder();

q.append("fragment multiply on Whatever { field { " +
"... on Abstract1 { field { leaf } } " +
"... on Abstract2 { field { leaf } } " +
"... on Concrete1 { field { leaf } } " +
"... on Concrete2 { field { leaf } } } } " +
"query DeepAbstractConcrete { ");

for (int i = 1; i <= depth; i++) {
q.append("field { ...multiply ");
}

for (int i = 1; i <= depth; i++) {
q.append(" }");
}

q.append("\n}");

return Parser.parse(q.toString());
}
}
Loading