Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Performance pipeline improvements #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into from
Apr 3, 2025
Merged

Performance pipeline improvements #3867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/commit_performance_result.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
echo "Performance results already present"
exit 0
fi
git pull
git commit -m "Add performance results for commit ${{ github.event.inputs.sha }}"
git push

6 changes: 5 additions & 1 deletion .github/workflows/publish_commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
name: Publish Commit SHA for performance testing
on:
push:
pull_request:
types:
- closed
Copy link
Member

@andimarek andimarek Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed, but not merged? Or does close mean merged here?

Copy link
Member Author

@dondonz dondonz Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no specific "merged" event. See the documentation, I thought "closed" would be the closest to what we want https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

branches:
- master
paths-ignore:
- 'performance-results/**'
permissions:
id-token: write # This is required for requesting the JWT
contents: read # This is required for actions/checkout
Expand Down
Loading