Draft - Update to Shadow 9.x and configure special task #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 326 files 326 suites 3m 33s ⏱️ Results for commit 5459d4b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the major Shadow 9.x update, the fat JMH JAR wasn't correctly created. Found that out when our JMH pipeline failed, our runner couldn't find the main class to start the tests.
Shadow 9.x has many breaking changes, I suspect some of them changed default custom task config behaviour. This PR explicitly sets JMH configuration instead.
Note that you can't "test" this with our unit tests, they are passing but doesn't indicate anything. The real test is if we can run our JMH performance pipeline off this pull request.
This is a draft, I'll come back to this later