Make print_block_string work with string proxy objects (#153)

fugal-dy · web-flow · commit 02f349be77c9 · 2021-12-27T15:29:25.000+01:00
diff --git a/src/graphql/language/block_string.py b/src/graphql/language/block_string.py
@@ -83,6 +83,9 @@ def print_block_string(value: str, prefer_multiple_lines: bool = False) -> str:
 
     For internal use only.
     """
+    if not isinstance(value, str):
+        value = str(value)  # resolve lazy string proxy object
+
     is_single_line = "\n" not in value
     has_leading_space = value.startswith(" ") or value.startswith("\t")
     has_trailing_quote = value.endswith('"')
@@ -95,12 +98,12 @@ def print_block_string(value: str, prefer_multiple_lines: bool = False) -> str:
     )
 
     # Format a multi-line block quote to account for leading space.
-    result = (
+    before = (
         "\n"
         if print_as_multiple_lines and not (is_single_line and has_leading_space)
         else ""
-    ) + value
-    if print_as_multiple_lines:
-        result += "\n"
+    )
+    after = "\n" if print_as_multiple_lines else ""
+    value = value.replace('"""', '\\"""')
 
-    return '"""' + result.replace('"""', '\\"""') + '"""'
+    return f'"""{before}{value}{after}"""'
diff --git a/tests/language/test_block_string.py b/tests/language/test_block_string.py
@@ -1,3 +1,5 @@
+from typing import cast
+
 from graphql.language.block_string import (
     dedent_block_string_value,
     print_block_string,
@@ -144,3 +146,10 @@ def correctly_prints_string_with_a_first_line_indentation():
         assert print_block_string(s) == join_lines(
             '"""', "    first  ", "  line     ", "indentation", "     string", '"""'
         )
+
+    def correctly_prints_lazy_stings():
+        class LazyString:
+            def __str__(self):
+                return "lazy"
+
+        assert print_block_string(cast(str, LazyString())) == '"""lazy"""'
