Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 2c7be0d

Browse files
authored
Merge pull request #3022 from adumesny/master
remove ES5 support
2 parents adfa34a + 0e616c7 commit 2c7be0d

9 files changed

+9
-417
lines changed

Gruntfile.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ module.exports = function(grunt) {
3838
copy: {
3939
dist: {
4040
files: {
41-
'dist/es5/gridstack-poly.js': ['src/gridstack-poly.js'],
4241
'dist/src/gridstack.scss': ['src/gridstack.scss'],
4342
'dist/angular/README.md': ['angular/README.md'],
4443
'dist/angular/src/gridstack.component.ts': ['angular/projects/lib/src/lib/gridstack.component.ts'],

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Alternatively (single combined file, notice the -all.js) in html
8888
<script src="node_modules/gridstack/dist/gridstack-all.js"></script>
8989
```
9090

91-
**Note**: IE support was dropped in v2, but restored in v4.4 by an external contributor (I have no interest in testing+supporting obsolete browser so this likely will break again in the future).
91+
**Note**: IE support was dropped in v2, but restored in v4.4 by an external contributor (I have no interest in testing+supporting obsolete browser so this likely will break again in the future) and DROPPED again in v12 (css variable needed).
9292
You can use the es5 files and polyfill (larger) for older browser instead. For example:
9393
```html
9494
<link href="node_modules/gridstack/dist/gridstack.min.css" rel="stylesheet"/>

demo/web1.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
<script type="module" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.esm.js"></script>
1414
<script nomodule="" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script>
1515

16-
<!-- support for IE -->
17-
<script src="../dist/es5/gridstack-poly.js"></script>
18-
<script src="../dist/es5/gridstack-all.js"></script>
16+
<script src="../dist/gridstack-all.js"></script>
1917
</head>
2018

2119
<body>

demo/web2.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
<script type="module" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.esm.js"></script>
1414
<script nomodule="" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script>
1515

16-
<!-- support for IE -->
17-
<script src="../dist/es5/gridstack-poly.js"></script>
18-
<script src="../dist/es5/gridstack-all.js"></script>
16+
<script src="../dist/gridstack-all.js"></script>
1917

2018
<style type="text/css">
2119
.grid-stack-item-removing {

doc/CHANGES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Change log
55
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
66
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*
77

8+
- [12.0.0-dev (TBD)](#1200-dev-tbd)
89
- [12.0.0 (2025-04-12)](#1200-2025-04-12)
910
- [11.5.1 (2025-03-23)](#1151-2025-03-23)
1011
- [11.5.0 (2025-03-16)](#1150-2025-03-16)
@@ -123,6 +124,10 @@ Change log
123124
- [v0.1.0 (2014-11-18)](#v010-2014-11-18)
124125

125126
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
127+
128+
## 12.0.0-dev (TBD)
129+
* removed ES5 support (IE doesn't support CSS vars needed now)
130+
126131
## 12.0.0 (2025-04-12)
127132
* feat: [#2854](https://github.com/gridstack/gridstack.js/pull/2854) Removed dynamic stylesheet and migrated to CSS vars. Thank you [lmartorella](https://github.com/lmartorella)
128133
* feat: [#3013](https://github.com/gridstack/gridstack.js/pull/3013) columns no longer require custom classes nor `gridstack-extra.css` as we now use CSS vars.

es5/tsconfig.json

Lines changed: 0 additions & 29 deletions
This file was deleted.

es5/webpack.config.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@
2525
}
2626
],
2727
"scripts": {
28-
"build": "yarn --no-progress && yarn build:ng && grunt && yarn build:es6 && yarn build:es5 && yarn doc",
28+
"build": "yarn --no-progress && yarn build:ng && grunt && yarn build:es6 && yarn doc",
2929
"build:es6": "webpack && tsc --stripInternal",
30-
"build:es5": "webpack --config es5/webpack.config.js && tsc --stripInternal --project es5/tsconfig.json",
3130
"build:ng": "cd angular && yarn --no-progress && yarn build lib",
3231
"w": "webpack",
3332
"t": "rm -rf dist/* && grunt && tsc --stripInternal",

0 commit comments

Comments
 (0)