Merge pull request #1312 from adumesny/develop

adumesny · web-flow · commit 46b6cd1adae0 · 2020-07-29T09:13:20.000-07:00
fix #1311 var missing for domAttr
diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -36,7 +36,7 @@ Change log
 
 ## 1.1.2-dev (upcoming)
 
-TBD
+- fix [1311](https://github.com/gridstack/gridstack.js/issues/1311) domAttr is not defined
 
 ## 1.1.2 (2020-05-17)
 
diff --git a/src/gridstack.js b/src/gridstack.js
@@ -1489,7 +1489,7 @@
     el = $(el);
     if (opt) { // see knockout above
       // make sure we load any DOM attributes that are not specified in passed in options (which override)
-      domAttr = this._readAttr(el);
+      var domAttr = this._readAttr(el);
       Utils.defaults(opt, domAttr);
       this.engine._prepareNode(opt);
     }

Original file line number	Diff line number	Diff line change
`@@ -1489,7 +1489,7 @@`
`1489`	`1489`	`el = $(el);`
`1490`	`1490`	`if (opt) { // see knockout above`
`1491`	`1491`	`// make sure we load any DOM attributes that are not specified in passed in options (which override)`
`1492`		`- domAttr = this._readAttr(el);`
	`1492`	`+ var domAttr = this._readAttr(el);`
`1493`	`1493`	`Utils.defaults(opt, domAttr);`
`1494`	`1494`	`this.engine._prepareNode(opt);`
`1495`	`1495`	`}`