mobile: nested grid drag out fix

adumesny · adumesny · commit 815f04c090b6 · 2024-12-08T18:42:51.000-08:00
* fix #2887 * make sure we check for null since dragging a child out will destroy the old one, doing a double cleaning.
diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -121,6 +121,7 @@ Change log
 ## 11.1.1-dev (TBD)
 * fix: [#2877](https://github.com/gridstack/gridstack.js/pull/2877) angular wrapper uses standalone, while now being compatible down to ng14. thanks to [andre-steudel](https://github.com/andre-steudel)
 * fix: [#2886](https://github.com/gridstack/gridstack.js/issues/2886) added `gs-size-to-content` support
+* fix: [#2887](https://github.com/gridstack/gridstack.js/issues/2887) mobile nested grid TypeError: e.currentTarget is null
 
 ## 11.1.1 (2024-11-26)
 * fix: [#2878](https://github.com/gridstack/gridstack.js/pull/2878) make sure sub-grid inherit parent opts by default, with subgrid defaults.
diff --git a/src/dd-draggable.ts b/src/dd-draggable.ts
@@ -224,7 +224,7 @@ export class DDDraggable extends DDBaseImplement implements HTMLElementExtendOpt
   protected _mouseUp(e: MouseEvent): void {
     document.removeEventListener('mousemove', this._mouseMove, true);
     document.removeEventListener('mouseup', this._mouseUp, true);
-    if (isTouch) {
+    if (isTouch && e.currentTarget) { // destroy() during nested grid call us again wit fake _mouseUp
       e.currentTarget.removeEventListener('touchmove', touchmove, true);
       e.currentTarget.removeEventListener('touchend', touchend, true);
     }

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ export class DDDraggable extends DDBaseImplement implements HTMLElementExtendOpt`
`224`	`224`	`protected _mouseUp(e: MouseEvent): void {`
`225`	`225`	`document.removeEventListener('mousemove', this._mouseMove, true);`
`226`	`226`	`document.removeEventListener('mouseup', this._mouseUp, true);`
`227`		`- if (isTouch) {`
	`227`	`+ if (isTouch && e.currentTarget) { // destroy() during nested grid call us again wit fake _mouseUp`
`228`	`228`	`e.currentTarget.removeEventListener('touchmove', touchmove, true);`
`229`	`229`	`e.currentTarget.removeEventListener('touchend', touchend, true);`
`230`	`230`	`}`