fix issue on failed drag makes the whole grid unresponsive (#2672)

mustafamilyas · web-flow · commit 9b6c68fc04bb · 2024-05-16T09:03:52.000-07:00
* fix issue on failed drag, shouldn't throw an error

* move the code to orinal position, use optional chaining instead
diff --git a/src/gridstack.ts b/src/gridstack.ts
@@ -2252,7 +2252,7 @@ export class GridStack {
           this.engine.cleanupNode(node); // removes all internal _xyz values
           node.grid = this;
         }
-        delete node.grid._isTemp;
+        delete node.grid?._isTemp;
         dd.off(el, 'drag');
         // if we made a copy ('helper' which is temp) of the original node then insert a copy, else we move the original node (#1102)
         // as the helper will be nuked by jquery-ui otherwise. TODO: update old code path
diff --git a/src/utils.ts b/src/utils.ts
@@ -111,9 +111,9 @@ export class Utils {
 
   /** true if we should resize to content. strict=true when only 'sizeToContent:true' and not a number which lets user adjust */
   static shouldSizeToContent(n: GridStackNode | undefined, strict = false): boolean {
-    return n?.grid && (strict ? 
-    (n.sizeToContent === true || (n.grid.opts.sizeToContent === true && n.sizeToContent === undefined)) :
-    (!!n.sizeToContent || (n.grid.opts.sizeToContent && n.sizeToContent !== false)));
+    return n?.grid && (strict ?
+      (n.sizeToContent === true || (n.grid.opts.sizeToContent === true && n.sizeToContent === undefined)) :
+      (!!n.sizeToContent || (n.grid.opts.sizeToContent && n.sizeToContent !== false)));
   }
 
   /** returns true if a and b overlap */

Original file line number	Diff line number	Diff line change
`@@ -2252,7 +2252,7 @@ export class GridStack {`
`2252`	`2252`	`this.engine.cleanupNode(node); // removes all internal _xyz values`
`2253`	`2253`	`node.grid = this;`
`2254`	`2254`	`}`
`2255`		`- delete node.grid._isTemp;`
	`2255`	`+ delete node.grid?._isTemp;`
`2256`	`2256`	`dd.off(el, 'drag');`
`2257`	`2257`	`// if we made a copy ('helper' which is temp) of the original node then insert a copy, else we move the original node (#1102)`
`2258`	`2258`	`// as the helper will be nuked by jquery-ui otherwise. TODO: update old code path`