From 57a25638e88954667f7eb34d0a59851ebc9a9a50 Mon Sep 17 00:00:00 2001 From: John Cormie Date: Mon, 21 Oct 2024 15:55:05 -0700 Subject: [PATCH 1/2] Update binderDied() error description to spell out the possibilities for those unfamiliar with Android internals. --- .../src/main/java/io/grpc/binder/internal/BinderTransport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java index 81eecf975bf..86f2376ebd7 100644 --- a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java +++ b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java @@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) { @Override public synchronized void binderDied() { - shutdownInternal(Status.UNAVAILABLE.withDescription("binderDied"), true); + shutdownInternal(Status.UNAVAILABLE.withDescription("Peer crashed, exited or was killed (binderDied)"), true); } @GuardedBy("this") From 8cf614c968e8f67b6f0fc072f8b30bf3c17507f7 Mon Sep 17 00:00:00 2001 From: John Cormie Date: Mon, 21 Oct 2024 15:55:43 -0700 Subject: [PATCH 2/2] spell out peer a bit more for those unfamiliar with client/server networking terms --- .../src/main/java/io/grpc/binder/internal/BinderTransport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java index 86f2376ebd7..8c428fac98c 100644 --- a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java +++ b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java @@ -299,7 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) { @Override public synchronized void binderDied() { - shutdownInternal(Status.UNAVAILABLE.withDescription("Peer crashed, exited or was killed (binderDied)"), true); + shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true); } @GuardedBy("this")