Fix: Callback with an error even if Promise is rejected with nothing (closes #42)

phated · phated · commit 77d00f9fe667 · 2017-08-04T14:16:28.000-07:00
diff --git a/index.js b/index.js
@@ -29,6 +29,9 @@ function asyncDone(fn, cb) {
   }
 
   function onError(error) {
+    if (!error) {
+      error = new Error('Promise rejected without Error');
+    }
     return done(error);
   }
 
diff --git a/test/promises.js b/test/promises.js
@@ -14,6 +14,10 @@ function failure() {
   return when.reject(new Error('Promise Error'));
 }
 
+function rejectNoError() {
+  return when.reject();
+}
+
 describe('promises', function() {
 
   it('should handle a resolved promise', function(done) {
@@ -29,4 +33,12 @@ describe('promises', function() {
       done();
     });
   });
+
+  it('properly errors when rejected without an error', function(done) {
+    asyncDone(rejectNoError, function(err) {
+      expect(err).toExist();
+      expect(err).toBeAn(Error);
+      done();
+    });
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,9 @@ function asyncDone(fn, cb) {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`function onError(error) {`
	`32`	`+ if (!error) {`
	`33`	`+ error = new Error('Promise rejected without Error');`
	`34`	`+ }`
`32`	`35`	`return done(error);`
`33`	`36`	`}`
`34`	`37`