From bc3619437ed5ff10ecffa8c836d2f1ca2ad5de68 Mon Sep 17 00:00:00 2001 From: Mahmudul Hazra Date: Mon, 4 Nov 2019 21:10:30 +0100 Subject: [PATCH 01/10] test(repository): fixes linting errors --- test/repository.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/repository.spec.js b/test/repository.spec.js index 7102874b..4cd46a76 100644 --- a/test/repository.spec.js +++ b/test/repository.spec.js @@ -392,7 +392,7 @@ describe('Repository', function() { expect(fileText).to.be(initialText); done(); - }))) + }))); }); it('should rename files', function(done) { From 95fb236fb18d03eee6e8e7abb0a291c3f20dc5d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Cala=C3=A7a?= Date: Wed, 6 Nov 2019 18:51:13 -0300 Subject: [PATCH 02/10] improve(repository): add list commits on pull request function --- lib/Repository.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lib/Repository.js b/lib/Repository.js index daf9443f..74452dde 100644 --- a/lib/Repository.js +++ b/lib/Repository.js @@ -198,6 +198,23 @@ class Repository extends Requestable { return this._request('GET', `/repos/${this.__fullname}/commits`, options, cb); } + /** + * List the commits on a pull request + * @see https://developer.github.com/v3/repos/commits/#list-commits-on-a-repository + * @param {number|string} number - the number of the pull request to list the commits + * @param {Object} [options] - the filtering options for commits + * @param {Requestable.callback} [cb] - will receive the commits information + * @return {Promise} - the promise for the http request + */ + listCommitsOnPR(number, options, cb) { + options = options || {}; + if (typeof options === 'function') { + cb = options; + options = {}; + } + return this._request('GET', `/repos/${this.__fullname}/pulls/${number}/commits`, options, cb); + } + /** * Gets a single commit information for a repository * @see https://developer.github.com/v3/repos/commits/#get-a-single-commit From ba74ee2196a48d619241691b27630b9d32bc8b98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ot=C3=A1vio=20Cala=C3=A7a?= Date: Wed, 6 Nov 2019 18:52:15 -0300 Subject: [PATCH 03/10] test(repository): add specs to test the new listCommitsOnPR function --- test/repository.spec.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/test/repository.spec.js b/test/repository.spec.js index 7102874b..2d71b04f 100644 --- a/test/repository.spec.js +++ b/test/repository.spec.js @@ -173,6 +173,24 @@ describe('Repository', function() { })); }); + it('should list commits on a PR with no options', function(done) { + const PR_NUMBER = 588; + remoteRepo.listCommitsOnPR(PR_NUMBER, assertSuccessful(done, function(err, commits) { + expect(commits).to.be.an.array(); + expect(commits.length).to.be.equal(2); + + let message1 = 'fix(repository): prevents lib from crashing when not providing optional arguments'; + expect(commits[0].author).to.have.own('login', 'hazmah0'); + expect(commits[0].commit).to.have.own('message', message1); + + let message2 = 'test(repository): updates test to use promise instead of callback'; + expect(commits[1].author).to.have.own('login', 'hazmah0'); + expect(commits[1].commit).to.have.own('message', message2); + + done(); + })); + }); + it('should get the latest commit from master', function(done) { remoteRepo.getSingleCommit('master', assertSuccessful(done, function(err, commit) { expect(commit).to.have.own('sha'); From 3b4b7b02a2308ce8106c2f92667c092602c66c79 Mon Sep 17 00:00:00 2001 From: Jivthesh M R Date: Thu, 6 Aug 2020 23:23:37 +0530 Subject: [PATCH 04/10] added code of conduct --- CODE_OF_CONDUCT.md | 76 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 CODE_OF_CONDUCT.md diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md new file mode 100644 index 00000000..09827eb1 --- /dev/null +++ b/CODE_OF_CONDUCT.md @@ -0,0 +1,76 @@ +# Contributor Covenant Code of Conduct + +## Our Pledge + +In the interest of fostering an open and welcoming environment, we as +contributors and maintainers pledge to making participation in our project and +our community a harassment-free experience for everyone, regardless of age, body +size, disability, ethnicity, sex characteristics, gender identity and expression, +level of experience, education, socio-economic status, nationality, personal +appearance, race, religion, or sexual identity and orientation. + +## Our Standards + +Examples of behavior that contributes to creating a positive environment +include: + +* Using welcoming and inclusive language +* Being respectful of differing viewpoints and experiences +* Gracefully accepting constructive criticism +* Focusing on what is best for the community +* Showing empathy towards other community members + +Examples of unacceptable behavior by participants include: + +* The use of sexualized language or imagery and unwelcome sexual attention or + advances +* Trolling, insulting/derogatory comments, and personal or political attacks +* Public or private harassment +* Publishing others' private information, such as a physical or electronic + address, without explicit permission +* Other conduct which could reasonably be considered inappropriate in a + professional setting + +## Our Responsibilities + +Project maintainers are responsible for clarifying the standards of acceptable +behavior and are expected to take appropriate and fair corrective action in +response to any instances of unacceptable behavior. + +Project maintainers have the right and responsibility to remove, edit, or +reject comments, commits, code, wiki edits, issues, and other contributions +that are not aligned to this Code of Conduct, or to ban temporarily or +permanently any contributor for other behaviors that they deem inappropriate, +threatening, offensive, or harmful. + +## Scope + +This Code of Conduct applies both within project spaces and in public spaces +when an individual is representing the project or its community. Examples of +representing a project or community include using an official project e-mail +address, posting via an official social media account, or acting as an appointed +representative at an online or offline event. Representation of a project may be +further defined and clarified by project maintainers. + +## Enforcement + +Instances of abusive, harassing, or otherwise unacceptable behavior may be +reported by contacting the project team at . All +complaints will be reviewed and investigated and will result in a response that +is deemed necessary and appropriate to the circumstances. The project team is +obligated to maintain confidentiality with regard to the reporter of an incident. +Further details of specific enforcement policies may be posted separately. + +Project maintainers who do not follow or enforce the Code of Conduct in good +faith may face temporary or permanent repercussions as determined by other +members of the project's leadership. + +## Attribution + +This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, +available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html + +[homepage]: https://www.contributor-covenant.org + +For answers to common questions about this code of conduct, see +https://www.contributor-covenant.org/faq From dfe3df43593d6a2378fd57e789129ff35c798aa1 Mon Sep 17 00:00:00 2001 From: Nick Lynch Date: Fri, 22 Jan 2021 11:35:26 +0000 Subject: [PATCH 05/10] chore: update axios due to CVE There's a CVE for axios < 0.21.1. See https://github.com/advisories/GHSA-4w2v-q235-vp99 Closes #633 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b3c78db3..42b1c81f 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ "dist/*" ], "dependencies": { - "axios": "^0.19.0", + "axios": "^0.21.1", "debug": "^2.2.0", "js-base64": "^2.1.9", "utf8": "^2.1.1" From b11839534abe38b1c5b84afa46f2fa9f91d2b28f Mon Sep 17 00:00:00 2001 From: Jared Rewerts Date: Sun, 24 Jan 2021 16:30:23 -0800 Subject: [PATCH 06/10] Fixed auth message. --- test/auth.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/auth.spec.js b/test/auth.spec.js index d1aea684..00842ee9 100644 --- a/test/auth.spec.js +++ b/test/auth.spec.js @@ -84,7 +84,7 @@ describe('Github', function() { it('should fail authentication and return err', function(done) { user.listNotifications(assertFailure(done, function(err) { expect(err.response.status).to.be.equal(401, 'Return 401 status for bad auth'); - expect(err.response.data.message).to.equal('Bad credentials'); + expect(err.response.data.message).to.equal('Requires authentication'); done(); })); From 606bcc8791b55b5132b7e919739efa29c809bd63 Mon Sep 17 00:00:00 2001 From: Jared Rewerts Date: Sun, 24 Jan 2021 16:54:15 -0800 Subject: [PATCH 07/10] Update markdown response. --- test/markdown.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/markdown.spec.js b/test/markdown.spec.js index bd9e7c37..909581fa 100644 --- a/test/markdown.spec.js +++ b/test/markdown.spec.js @@ -37,7 +37,7 @@ describe('Markdown', function() { }; markdown.render(options) .then(function({data: html}) { - expect(html).to.be('

Hello world github/linguist#1 cool, and gollum#1!

'); // eslint-disable-line + expect(html).to.be('

Hello world github/linguist#1 cool, and gollum#1!

'); // eslint-disable-line done(); }).catch(done); }); From c8ab54b8c737ae0a1af63f45757d5147c8f54ee2 Mon Sep 17 00:00:00 2001 From: Jared Rewerts Date: Sun, 24 Jan 2021 17:50:00 -0800 Subject: [PATCH 08/10] 3.4.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 42b1c81f..8e54341a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "github-api", - "version": "3.3.0", + "version": "3.4.0", "license": "BSD-3-Clause-Clear", "description": "A higher-level wrapper around the Github API.", "main": "dist/components/GitHub.js", From 935488e16eb7ea26f2ed9c3ccd8b911318f7553d Mon Sep 17 00:00:00 2001 From: luisborit Date: Tue, 26 Jan 2021 01:38:19 -0500 Subject: [PATCH 09/10] corrected link --- lib/User.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/User.js b/lib/User.js index d6470324..64d377fd 100644 --- a/lib/User.js +++ b/lib/User.js @@ -93,7 +93,7 @@ class User extends Requestable { /** * List users followed by another user - * @see https://developer.github.com/v3/users/followers/#list-users-followed-by-another-user + * @see https://docs.github.com/en/rest/reference/users#list-the-people-the-authenticated-user-follows * @param {Requestable.callback} [cb] - will receive the list of who a user is following * @return {Promise} - the promise for the http request */ From ac6cd1f69e4770ced303c4a9723239f3266cca57 Mon Sep 17 00:00:00 2001 From: luisborit Date: Thu, 4 Feb 2021 23:48:09 -0500 Subject: [PATCH 10/10] comment edited --- lib/User.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/User.js b/lib/User.js index 64d377fd..a6f22324 100644 --- a/lib/User.js +++ b/lib/User.js @@ -92,7 +92,7 @@ class User extends Requestable { } /** - * List users followed by another user + * Lists the people who the authenticated user follows. * @see https://docs.github.com/en/rest/reference/users#list-the-people-the-authenticated-user-follows * @param {Requestable.callback} [cb] - will receive the list of who a user is following * @return {Promise} - the promise for the http request