Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve PCAN installation procedure #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Improve PCAN installation procedure #1093

merged 3 commits into from
Jun 15, 2021

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented Jun 14, 2021

Fixes #1053.

This PR:

  • prints a warning if uptime is missing in PCAN
  • Adds a setup.py-extra to be able to easily install it
  • Changes the documentation accordingly
  • Fixes some small documentation issues like old links, non-HTTPS links and formatting

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1093 (8639684) into develop (8e6f05a) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop    #1093      +/-   ##
===========================================
- Coverage    70.71%   70.68%   -0.04%     
===========================================
  Files           79       79              
  Lines         7616     7617       +1     
===========================================
- Hits          5386     5384       -2     
- Misses        2230     2233       +3     

@mergify mergify bot requested a review from hardbyte June 14, 2021 09:37
@felixdivo felixdivo merged commit 0ebb0a3 into develop Jun 15, 2021
@felixdivo felixdivo deleted the pcan-specific-setup branch June 15, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pcan timestamps are silently incorrect on windows, (without uptime installed)
2 participants