Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding env marker to pywin32 requirements (extra) #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

pierreluctg
Copy link
Collaborator

As part of #1833, the pywin32 requirements environment markers got dropped when moving the requirement to an extra.

As part of #1833, the `pywin32` requirements environment markers got dropped when moving the requirement to an extra.
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intentional. I thought: If the user explicitely requests pywin32, then installation should fail if it is not available.

But i can see use cases, where that might be annoying, so approved :)

@pierreluctg pierreluctg merged commit 8e685ac into main Feb 3, 2025
64 checks passed
@pierreluctg pierreluctg deleted the pywin32-req-env-marker branch February 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants