Add Travis CI support for arm64 architectures #705
Conversation
Add support for the arm64 architecture from Travis CI's alpha offering. This enables the test suite to run within an arm64 LXD container (minus the tests that exercise SocketCAN, as the image is missing the required kernel modules).
|
Proof that the worker is running on |
Codecov Report
@@ Coverage Diff @@
## develop #705 +/- ##
========================================
Coverage 69.52% 69.52%
========================================
Files 70 70
Lines 6485 6485
========================================
Hits 4509 4509
Misses 1976 1976 |
|
I don’t want to be boring and all, but what part of the library needs testing on specific architectures? |
|
Not really specific architectures, but there's code that relies on various sizes and alignments of types. The only way to really cover that besides mocking is to run the tests on different build environments. There's also #591 in the backlog which calls out ARM testing. |
|
I know SocketCAN and PCAN have some OS and architectural differences so if we could test against the actual drivers then there would definitely be a point. But if we can’t test the integration then I can’t see how that increases our confidence. It does consume more resources and requires future maintenance so I think we need to investigate which tests will benefit from this. |
There was a problem hiding this comment.
I really like this an think it replaces & closes #591. The maintenance effort is reasonable and it checks some code for which it's worth.
@christiansandberg I agree that we should somehow limit it though. Testing only a single Python version is a good compromise there.
That's my opinion, this surely is disputable.
|
How are we going to proceed on this? Letting this rot here isn't too helpful either. |
Add support for the arm64 architecture from Travis CI's alpha offering.
This enables the test suite to run within an arm64 LXD container (minus
the tests that exercise SocketCAN, as the image is missing the required
kernel modules).