Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9021c39

Browse files
authored
Add -Wunused-packages to common warnings (#4053)
* Add -Wunused-packages to common warnings * Get rid of common deps * Wrapper needs process on windows * Refine * Does it work like this? * More cleanups in ghcide * Fix build with stack * Also fix stack --test * Less noisy workaround * Fix new warnings
1 parent 03efae6 commit 9021c39

File tree

5 files changed

+88
-162
lines changed

5 files changed

+88
-162
lines changed

ghcide/ghcide.cabal

+2-20
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ homepage:
1414
https://github.com/haskell/haskell-language-server/tree/master/ghcide#readme
1515

1616
bug-reports: https://github.com/haskell/haskell-language-server/issues
17-
tested-with: GHC == 9.8.1 || ==9.6.4 || ==9.4.8 || ==9.2.8
17+
tested-with: GHC ==9.8.1 || ==9.6.4 || ==9.4.8 || ==9.2.8
1818
extra-source-files:
1919
CHANGELOG.md
2020
README.md
@@ -215,11 +215,8 @@ library
215215
Development.IDE.Types.Action
216216

217217
if flag(pedantic)
218-
-- We eventually want to build with Werror fully, but we haven't
219-
-- finished purging the warnings, so some are set to not be errors
220-
-- for now
221218
ghc-options:
222-
-Werror -Wwarn=unused-packages
219+
-Werror
223220

224221
if flag(ekg)
225222
build-depends:
@@ -283,13 +280,6 @@ executable ghcide
283280
if !flag(executable)
284281
buildable: False
285282

286-
if flag(ekg)
287-
build-depends:
288-
, ekg-core
289-
, ekg-wai
290-
291-
cpp-options: -DMONITORING_EKG
292-
293283
test-suite ghcide-tests
294284
import: warnings
295285
type: exitcode-stdio-1.0
@@ -310,14 +300,6 @@ test-suite ghcide-tests
310300
, extra
311301
, filepath
312302
, fuzzy
313-
--------------------------------------------------------------
314-
-- The MIN_VERSION_ghc macro relies on MIN_VERSION pragmas
315-
-- which require depending on ghc. So the tests need to depend
316-
-- on ghc if they need to use MIN_VERSION_ghc. Maybe a
317-
-- better solution can be found, but this is a quick solution
318-
-- which works for now.
319-
--------------------------------------------------------------
320-
, ghc
321303
, ghcide
322304
, hls-plugin-api
323305
, lens

0 commit comments

Comments
 (0)