Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add cluster autoscaler#210

Draft
gytis-ivaskevicius wants to merge 1 commit into
hcloud-talos:mainfrom
gytis-ivaskevicius:main
Draft

feat: add cluster autoscaler#210
gytis-ivaskevicius wants to merge 1 commit into
hcloud-talos:mainfrom
gytis-ivaskevicius:main

Conversation

@gytis-ivaskevicius
Copy link
Copy Markdown

@gytis-ivaskevicius gytis-ivaskevicius commented May 9, 2025

Added autoscaler, I feel like it either needs a feature flag to enable it, or we need to get rid of the existing workers implementation, since there is not much point in having it if the cluster autoscales on its own

Please let me know what the next steps should be

Resolves: #16

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2025

Commitlint-Check

Thanks for your contribution ❤️

commitlint has detected that all commit messages in this PR follow the conventional commit format 🎉

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2025

Terraform-Check (version: 1.8.5): ❌

🖌 Terraform Format: ❌ 
# Outputs:
autoscaler.tf
--- old/autoscaler.tf
+++ new/autoscaler.tf
@@ -149,7 +149,7 @@
     extraEnvSecrets = {
       HCLOUD_TOKEN = {
         name = "hetzner-api-token"
-        key = "token"
+        key  = "token"
       }
     }
 


# Errors:
⚙️ Terraform Init: ✅ 
# Outputs:

Initializing the backend...

Initializing provider plugins...
- Finding alekc/kubectl versions matching ">= 2.1.3"...
- Finding hashicorp/tls versions matching ">= 4.0.6"...
- Finding latest version of hashicorp/kubernetes...
- Finding hetznercloud/hcloud versions matching ">= 1.50.1"...
- Finding siderolabs/talos versions matching ">= 0.7.1"...
- Finding hashicorp/http versions matching ">= 3.4.5"...
- Finding hashicorp/helm versions matching ">= 2.17.0"...
- Installing hashicorp/http v3.5.0...
- Installed hashicorp/http v3.5.0 (signed by HashiCorp)
- Installing hashicorp/helm v2.17.0...
- Installed hashicorp/helm v2.17.0 (signed by HashiCorp)
- Installing alekc/kubectl v2.1.3...
- Installed alekc/kubectl v2.1.3 (self-signed, key ID 772FB27A86DAFCE7)
- Installing hashicorp/tls v4.1.0...
- Installed hashicorp/tls v4.1.0 (signed by HashiCorp)
- Installing hashicorp/kubernetes v2.36.0...
- Installed hashicorp/kubernetes v2.36.0 (signed by HashiCorp)
- Installing hetznercloud/hcloud v1.50.1...
- Installed hetznercloud/hcloud v1.50.1 (signed by a HashiCorp partner, key ID 5219EACB3A77198B)
- Installing siderolabs/talos v0.8.0...
- Installed siderolabs/talos v0.8.0 (signed by a HashiCorp partner, key ID AF0815C7E2EC16A8)

Partner and community providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://www.terraform.io/docs/cli/plugins/signing.html

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.


# Errors:
🤖 Terraform Validate: ✅ 
# Outputs:
Success! The configuration is valid.



# Errors:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2025

Terraform-Check (version: 1.9.8): ❌

🖌 Terraform Format: ❌ 
# Outputs:
autoscaler.tf
--- old/autoscaler.tf
+++ new/autoscaler.tf
@@ -149,7 +149,7 @@
     extraEnvSecrets = {
       HCLOUD_TOKEN = {
         name = "hetzner-api-token"
-        key = "token"
+        key  = "token"
       }
     }
 


# Errors:
⚙️ Terraform Init: ✅ 
# Outputs:
Initializing the backend...
Initializing provider plugins...
- Finding hashicorp/helm versions matching ">= 2.17.0"...
- Finding alekc/kubectl versions matching ">= 2.1.3"...
- Finding hashicorp/tls versions matching ">= 4.0.6"...
- Finding hetznercloud/hcloud versions matching ">= 1.50.1"...
- Finding latest version of hashicorp/kubernetes...
- Finding siderolabs/talos versions matching ">= 0.7.1"...
- Finding hashicorp/http versions matching ">= 3.4.5"...
- Installing alekc/kubectl v2.1.3...
- Installed alekc/kubectl v2.1.3 (self-signed, key ID 772FB27A86DAFCE7)
- Installing hashicorp/tls v4.1.0...
- Installed hashicorp/tls v4.1.0 (signed by HashiCorp)
- Installing hetznercloud/hcloud v1.50.1...
- Installed hetznercloud/hcloud v1.50.1 (signed by a HashiCorp partner, key ID 5219EACB3A77198B)
- Installing hashicorp/kubernetes v2.36.0...
- Installed hashicorp/kubernetes v2.36.0 (signed by HashiCorp)
- Installing siderolabs/talos v0.8.0...
- Installed siderolabs/talos v0.8.0 (signed by a HashiCorp partner, key ID AF0815C7E2EC16A8)
- Installing hashicorp/http v3.5.0...
- Installed hashicorp/http v3.5.0 (signed by HashiCorp)
- Installing hashicorp/helm v2.17.0...
- Installed hashicorp/helm v2.17.0 (signed by HashiCorp)
Partner and community providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://www.terraform.io/docs/cli/plugins/signing.html
Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.


# Errors:
🤖 Terraform Validate: ✅ 
# Outputs:
Success! The configuration is valid.



# Errors:

@mrclrchtr
Copy link
Copy Markdown
Member

mrclrchtr commented May 13, 2025

Hi, thank you very much. I am currently on vacation and will have a look at it next week.

@gytis-ivaskevicius
Copy link
Copy Markdown
Author

gytis-ivaskevicius commented May 14, 2025

I kinda ended up rewriting what you have here. Quite far from finished but this is what I currently have https://github.com/gytis-ivaskevicius/k8s-for-poor-people

@mrclrchtr
Copy link
Copy Markdown
Member

mrclrchtr commented Jun 1, 2025

Okay, I've looked at it and have a few comments that I'll write down if you want to continue developing the PR. Are you interested in continuing to develop it, or are you already at the point in the other repo where you're no longer interested in this PR?

@gytis-ivaskevicius
Copy link
Copy Markdown
Author

gytis-ivaskevicius commented Jun 3, 2025

Yeah, I don't think that im interested in further working on this PR mostly because my rewrite has come much further compared to this module (tho not complete yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for cluster auto scaling

2 participants

@gytis-ivaskevicius @mrclrchtr