Updated Definition to properly return warnings #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the Definition class's createDefinition method to properly propagate warnings from the underlying parsing operation. The PR fixes an issue where warnings generated during HED string parsing were not being returned to the caller.
- Fixed warning propagation in
Definition.createDefinitionmethod - Corrected spelling errors in code comments
- Added comprehensive test coverage for definition creation and management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/parser/definitionManager.js | Fixed warning propagation by merging warnings from parsing and definition creation |
| src/parser/parser.js | Corrected spelling error in comment ("assemploy" → "assemploy") |
| tests/otherTests/definitionManager.spec.js | Added comprehensive test suite for Definition and DefinitionManager classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.