perf(hibernate processor): fix nullable things in processor package

kingg22 · kingg22 · commit 959d71c29e2d · 2025-08-27T16:09:12.000-05:00
diff --git a/tooling/metamodel-generator/src/main/java/org/hibernate/processor/ClassWriter.java b/tooling/metamodel-generator/src/main/java/org/hibernate/processor/ClassWriter.java
@@ -29,6 +29,7 @@
 import java.util.List;
 import java.util.Set;
 
+import static java.util.Objects.requireNonNull;
 import static org.hibernate.processor.util.Constants.SPRING_COMPONENT;
 import static org.hibernate.processor.util.TypeUtils.getGeneratedClassFullyQualifiedName;
 import static org.hibernate.processor.util.TypeUtils.isMemberType;
@@ -270,7 +271,7 @@ private static String getGeneratedSuperclassName(Element superClassElement, bool
 
 	private static String getGeneratedClassName(TypeElement typeElement, boolean jakartaDataStyle) {
 		final String simpleName = typeElement.getSimpleName().toString();
-		final Element enclosingElement = typeElement.getEnclosingElement();
+		final Element enclosingElement = requireNonNull( typeElement.getEnclosingElement() );
 		return (enclosingElement instanceof TypeElement
 				? getGeneratedSuperclassName( enclosingElement, jakartaDataStyle )
 				: ((PackageElement) enclosingElement).getQualifiedName().toString())
diff --git a/tooling/metamodel-generator/src/main/java/org/hibernate/processor/Context.java b/tooling/metamodel-generator/src/main/java/org/hibernate/processor/Context.java
@@ -81,16 +81,16 @@ public final class Context {
 	 * Whether all mapping files are xml-mapping-metadata-complete. In this case no annotation processing will take
 	 * place.
 	 */
-	private Boolean fullyXmlConfigured;
+	private @Nullable Boolean fullyXmlConfigured;
 	private boolean addInjectAnnotation = false;
 	private boolean addDependentAnnotation = false;
 	private boolean addComponentAnnotation = false;
 	private boolean addNonnullAnnotation = false;
 	private boolean addGeneratedAnnotation = true;
 	private boolean addGenerationDate;
-	private String[] suppressedWarnings;
+	private String @Nullable [] suppressedWarnings;
 	private boolean addTransactionScopedAnnotation;
-	private AccessType persistenceUnitDefaultAccessType;
+	private @Nullable AccessType persistenceUnitDefaultAccessType;
 	private boolean generateJakartaDataStaticMetamodel;
 	private boolean quarkusInjection;
 	private boolean springInjection;
@@ -213,7 +213,7 @@ public boolean addSuppressWarningsAnnotation() {
 		return suppressedWarnings != null;
 	}
 
-	public String[] getSuppressedWarnings() {
+	public String @Nullable [] getSuppressedWarnings() {
 		return suppressedWarnings;
 	}
 
@@ -402,7 +402,7 @@ public void mappingDocumentFullyXmlConfigured(boolean fullyXmlConfigured) {
 				: this.fullyXmlConfigured && fullyXmlConfigured;
 	}
 
-	public AccessType getPersistenceUnitDefaultAccessType() {
+	public @Nullable AccessType getPersistenceUnitDefaultAccessType() {
 		return persistenceUnitDefaultAccessType;
 	}
 
diff --git a/tooling/metamodel-generator/src/main/java/org/hibernate/processor/HibernateProcessor.java b/tooling/metamodel-generator/src/main/java/org/hibernate/processor/HibernateProcessor.java
@@ -45,6 +45,7 @@
 import java.util.function.Function;
 
 import static java.lang.Boolean.parseBoolean;
+import static java.util.Objects.requireNonNull;
 import static javax.lang.model.util.ElementFilter.fieldsIn;
 import static javax.lang.model.util.ElementFilter.methodsIn;
 import static org.hibernate.processor.HibernateProcessor.ADD_GENERATED_ANNOTATION;
@@ -711,7 +712,7 @@ && hasAnnotation( element, ENTITY, MAPPED_SUPERCLASS )
 	}
 
 	private static boolean hasHandwrittenMetamodel(Element element) {
-		return element.getEnclosingElement().getEnclosedElements()
+		return requireNonNull( element.getEnclosingElement() ).getEnclosedElements()
 				.stream().anyMatch(e -> e.getSimpleName()
 						.contentEquals('_' + element.getSimpleName().toString()));
 	}
@@ -764,7 +765,7 @@ private void indexEnumValues(TypeMirror type) {
 			if ( fieldType.getKind() == ElementKind.ENUM ) {
 				for ( Element enumMember : fieldType.getEnclosedElements() ) {
 					if ( enumMember.getKind() == ElementKind.ENUM_CONSTANT ) {
-						final Element enclosingElement = fieldType.getEnclosingElement();
+						final Element enclosingElement = requireNonNull( fieldType.getEnclosingElement() );
 						final boolean hasOuterType =
 								enclosingElement.getKind().isClass() || enclosingElement.getKind().isInterface();
 						context.addEnumValue( fieldType.getQualifiedName().toString(),
