Fixed wrong attributes mapping

SilverFire · SilverFire · commit baf32e043dd7 · 2022-03-26T19:11:32.000+02:00
diff --git a/src/Message/CompletePurchaseResponse.php b/src/Message/CompletePurchaseResponse.php
@@ -55,7 +55,7 @@ public function isSuccessful()
      */
     public function getTransactionId()
     {
-        return $this->data->getId();
+        return $this->getPosData()['posData']['u'];
     }
 
     /**
diff --git a/tests/unit/Message/CompletePurchaseResponseTest.php b/tests/unit/Message/CompletePurchaseResponseTest.php
@@ -14,7 +14,7 @@ class CompletePurchaseResponseTest extends TestCase
 
     private $token = '';
     private $description = 'Test Transaction long description';
-    private $transactionId = 'S4hVo7z6XZQ3yDUyHyUJD7';
+    private $transactionId = 'someTransactionId';
     private $transactionReference = 'S4hVo7z6XZQ3yDUyHyUJD7';
     private $status = InvoiceStatus::Complete;
     private $amount = '14.01';
@@ -41,9 +41,9 @@ public function testSuccess()
         $invoice = new Invoice($this->amount, $this->currency);
         $invoice->setFullNotifications(true);
         $invoice->setItemDesc($this->description);
-        $invoice->setPosData(json_encode(['posData' => []]));
+        $invoice->setPosData(json_encode(['posData' => ['u' => $this->transactionId]]));
         $invoice->setStatus($this->status);
-        $invoice->setId($this->transactionId);
+        $invoice->setId($this->transactionReference);
         $response = new CompletePurchaseResponse($this->request, $invoice);
 
         $this->assertTrue($response->isSuccessful());
@@ -52,7 +52,7 @@ public function testSuccess()
         $this->assertSame($this->transactionId, $response->getTransactionId());
         $this->assertSame($this->transactionReference, $response->getTransactionReference());
         $this->assertSame('14.01', $response->getAmount());
-        $this->assertStringContainsString($this->transactionId, $response->getPayer());
+        $this->assertStringContainsString($this->transactionReference, $response->getPayer());
         $this->assertSame($this->currency, $response->getCurrency());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function isSuccessful()`
`55`	`55`	`*/`
`56`	`56`	`public function getTransactionId()`
`57`	`57`	`{`
`58`		`- return $this->data->getId();`
	`58`	`+ return $this->getPosData()['posData']['u'];`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`/**`