Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move constants to setup.py #10312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Move constants to setup.py #10312

merged 4 commits into from
Nov 3, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 3, 2017

Description:

  • Move constants which are only relevant for the setup to setup.py

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@@ -463,3 +432,6 @@
TEMPERATURE = 'temperature' # type: str
SPEED_MS = 'speed_ms' # type: str
ILLUMINANCE = 'illuminance' # type: str

WEEKDAYS = ['mon', 'tue', 'wed', 'thu', 'fri', 'sat', 'sun']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file

@balloob balloob merged commit 8132480 into dev Nov 3, 2017
@fabaff fabaff deleted the const-setup branch November 3, 2017 16:34
@balloob balloob mentioned this pull request Nov 17, 2017

from homeassistant.const import __version__, __short_version__
from setup import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the sphinx build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #12535

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants