Use constants for HTTP headers #10313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should use the constants from aiohttp.hdrs package. We shouldn't have http related stuff in our repo if possible |
fd87128 to
24b9ff4
Compare
balloob
reviewed
Nov 4, 2017
| CONTENT_TYPE: "application/x-www-form-urlencoded; charset=UTF-8", | ||
| HTTP_HEADER_X_REQUESTED_WITH: "XMLHttpRequest", | ||
| REFERER: "http://{}/".format(self.host), | ||
| CONNECTION: KEEP_ALIVE, |
There was a problem hiding this comment.
There is no reason to move these to constants. They can just remain strings. All constants that are in const.py will be loaded into memory of every HASS instance so only common constants should make it into that file. So let's keep things like X_REQUESTED_WITH, KEEP_ALIVE and NO_CACHE in this file.
There was a problem hiding this comment.
Sorry, I don't understand. Beside HTTP_HEADER_X_REQUESTED_WITH and NO_CACHE which are in const.py is the rest coming out of aiohttp.hdrs.
There was a problem hiding this comment.
Yeah, I meant that we shouldn't add any HTTP headers to const.py anymore.
balloob
approved these changes
Nov 4, 2017
e6710dc to
ca7bccc
Compare
balloob
approved these changes
Nov 4, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use constants for HTTP headers across platforms.
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass