Eight Sleep add REM type, Update async syntax, Catch API quirks #14937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachya
reviewed
Jun 14, 2018
| @@ -255,15 +269,17 @@ def state(self): | |||
| """Return the state of the sensor.""" | |||
| return self._state | |||
|
|
|||
| @asyncio.coroutine | |||
| def async_update(self): | |||
| async def async_update(self): | |||
| """Retrieve latest state.""" | |||
| _LOGGER.debug("Updating Room sensor: %s", self._sensor) | |||
| temp = self._eight.room_temperature() | |||
There was a problem hiding this comment.
Does this method call do any I/O? If it does and it's not awaited properly, you're going to lock the event loop.
There was a problem hiding this comment.
It does not. All the I/O happens in the async_update_heat_data and async_update_user_data functions in the master component file. You can see the library room_temperature() function here: https://github.com/mezz64/pyEight/blob/d6c8e351acb9e43fd88be045d23ea4c6111bc8ff/pyeight/eight.py#L172
balloob
approved these changes
Jun 15, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Bump pyEight version and add atributes to support new REM sleep type.
Update to new async syntax.
Catch possible None values for temperature before rounding.
Remove "Last in Bed" attribute since it is no longer updated accurately in the API. This is a breaking change for anyone using that attribute in an automation.
Related issue (if applicable): fixes #14492
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.