Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix tests #14959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2018
Merged

Fix tests #14959

merged 2 commits into from
Jun 14, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 14, 2018

Description:

We left 2 test dependencies unpinned, and guess what broke today…

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Jun 14, 2018
@ghost ghost assigned balloob Jun 14, 2018
@ghost ghost added the in progress label Jun 14, 2018
@balloob balloob merged commit b2440a6 into dev Jun 14, 2018
@ghost ghost removed the in progress label Jun 14, 2018
@balloob balloob deleted the fix-tests branch June 14, 2018 15:57
@balloob balloob mentioned this pull request Jun 22, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@balloob balloob

Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant