fix: align process command arguments to spec defenition (open-telemetry#4032)

tamirdavid · web-flow · commit eb287111ed1b · 2024-07-11T09:04:38.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+- Update sdk process resource detector `process.command_args` attribute to also include the executable itself
+  ([#4032](https://github.com/open-telemetry/opentelemetry-python/pull/4032))
 - Fix `start_time_unix_nano` for delta collection for explicit bucket histogram aggregation
   ([#4009](https://github.com/open-telemetry/opentelemetry-python/pull/4009))
 - Fix `start_time_unix_nano` for delta collection for sum aggregation
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py
@@ -348,7 +348,7 @@ def detect(self) -> "Resource":
         _process_executable_path = os.path.dirname(_process_executable_name)
         _process_command = sys.argv[0]
         _process_command_line = " ".join(sys.argv)
-        _process_command_args = sys.argv[1:]
+        _process_command_args = sys.argv
         resource_info = {
             PROCESS_RUNTIME_DESCRIPTION: sys.version,
             PROCESS_RUNTIME_NAME: sys.implementation.name,
diff --git a/opentelemetry-sdk/tests/resources/test_resources.py b/opentelemetry-sdk/tests/resources/test_resources.py
@@ -608,7 +608,7 @@ def test_process_detector(self):
         )
         self.assertEqual(
             aggregated_resource.attributes[PROCESS_COMMAND_ARGS],
-            tuple(sys.argv[1:]),
+            tuple(sys.argv),
         )
 
     def test_resource_detector_entry_points_default(self):

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,7 @@ def test_process_detector(self):`
`608`	`608`	`)`
`609`	`609`	`self.assertEqual(`
`610`	`610`	`aggregated_resource.attributes[PROCESS_COMMAND_ARGS],`
`611`		`- tuple(sys.argv[1:]),`
	`611`	`+ tuple(sys.argv),`
`612`	`612`	`)`
`613`	`613`
`614`	`614`	`def test_resource_detector_entry_points_default(self):`