Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e4d7a16

Browse files
committed
Removing try/resources so that the stream is not closed and error handling is reported correctly
1 parent f8932f7 commit e4d7a16

File tree

1 file changed

+47
-52
lines changed

1 file changed

+47
-52
lines changed

jaxrs/jaxrs-endpoint/src/main/java/org/javaee7/jaxrs/endpoint/TestServlet.java

Lines changed: 47 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
* only if the new code is made subject to such option by the copyright
3838
* holder.
3939
*/
40-
4140
package org.javaee7.jaxrs.endpoint;
4241

4342
import java.io.IOException;
@@ -61,9 +60,8 @@
6160
public class TestServlet extends HttpServlet {
6261

6362
/**
64-
* Processes requests for both HTTP
65-
* <code>GET</code> and
66-
* <code>POST</code> methods.
63+
* Processes requests for both HTTP <code>GET</code> and <code>POST</code>
64+
* methods.
6765
*
6866
* @param request servlet request
6967
* @param response servlet response
@@ -73,62 +71,60 @@ public class TestServlet extends HttpServlet {
7371
protected void processRequest(HttpServletRequest request, HttpServletResponse response)
7472
throws ServletException, IOException {
7573
response.setContentType("text/html;charset=UTF-8");
76-
try (PrintWriter out = response.getWriter()) {
77-
out.println("<html>");
78-
out.println("<head>");
79-
out.println("<title>JAX-RS Endpoint</title>");
80-
out.println("</head>");
81-
out.println("<body>");
82-
out.println("<h1>JAX-RS Endpoint</h1>");
83-
Client client = ClientBuilder.newClient();
84-
client.register(new LoggingFilter(Logger.getAnonymousLogger(), true));
85-
WebTarget target = client.target("http://"
86-
+ request.getServerName()
87-
+ ":"
88-
+ request.getServerPort()
89-
+ request.getContextPath()
90-
+ "/webresources/fruit");
91-
out.print("Got a target<br><br>");
74+
PrintWriter out = response.getWriter();
75+
out.println("<html>");
76+
out.println("<head>");
77+
out.println("<title>JAX-RS Endpoint</title>");
78+
out.println("</head>");
79+
out.println("<body>");
80+
out.println("<h1>JAX-RS Endpoint</h1>");
81+
Client client = ClientBuilder.newClient();
82+
client.register(new LoggingFilter(Logger.getAnonymousLogger(), true));
83+
WebTarget target = client.target("http://"
84+
+ request.getServerName()
85+
+ ":"
86+
+ request.getServerPort()
87+
+ request.getContextPath()
88+
+ "/webresources/fruit");
89+
out.print("Got a target<br><br>");
90+
91+
// POST
92+
out.print("POSTing...<br>");
93+
target.request().post(Entity.text("apple"));
94+
out.format("POSTed %1$s ...<br>", "apple");
9295

93-
// POST
94-
out.print("POSTing...<br>");
95-
target.request().post(Entity.text("apple"));
96-
out.format("POSTed %1$s ...<br>", "apple");
96+
// PUT
97+
out.print("<br>PUTing...<br>");
98+
target.request().put(Entity.text("banana"));
99+
out.format("PUTed %1$s ...<br>", "banana");
97100

98-
// PUT
99-
out.print("<br>PUTing...<br>");
100-
target.request().put(Entity.text("banana"));
101-
out.format("PUTed %1$s ...<br>", "banana");
101+
// GET (all)
102+
out.print("<br>GETing...<br>");
103+
String r = target.request().get(String.class);
104+
out.format("GETed %1$s items ...<br>", r);
102105

103-
// GET (all)
104-
out.print("<br>GETing...<br>");
105-
String r = target.request().get(String.class);
106-
out.format("GETed %1$s items ...<br>", r);
106+
// GET (one)
107+
out.print("<br>GETing...<br>");
108+
r = target.path("apple").request().get(String.class);
109+
out.format("GETed %1$s items ...<br>", r);
107110

108-
// GET (one)
109-
out.print("<br>GETing...<br>");
110-
r = target.path("apple").request().get(String.class);
111-
out.format("GETed %1$s items ...<br>", r);
111+
// DELETE
112+
out.print("<br>DELETEing...<br>");
113+
target.path("banana").request().delete();
114+
out.format("DELETEed %1$s items ...<br>", "banana");
112115

113-
// DELETE
114-
out.print("<br>DELETEing...<br>");
115-
target.path("banana").request().delete();
116-
out.format("DELETEed %1$s items ...<br>", "banana");
116+
// GET (all)
117+
out.print("<br>GETing...<br>");
118+
r = target.request().get(String.class);
119+
out.format("GETed %1$s items ...<br>", r);
117120

118-
// GET (all)
119-
out.print("<br>GETing...<br>");
120-
r = target.request().get(String.class);
121-
out.format("GETed %1$s items ...<br>", r);
122-
123-
out.println("</body>");
124-
out.println("</html>");
125-
}
121+
out.println("</body>");
122+
out.println("</html>");
126123
}
127124

128125
// <editor-fold defaultstate="collapsed" desc="HttpServlet methods. Click on the + sign on the left to edit the code.">
129126
/**
130-
* Handles the HTTP
131-
* <code>GET</code> method.
127+
* Handles the HTTP <code>GET</code> method.
132128
*
133129
* @param request servlet request
134130
* @param response servlet response
@@ -142,8 +138,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
142138
}
143139

144140
/**
145-
* Handles the HTTP
146-
* <code>POST</code> method.
141+
* Handles the HTTP <code>POST</code> method.
147142
*
148143
* @param request servlet request
149144
* @param response servlet response

0 commit comments

Comments
 (0)