Explicitly type Controller.dispatch() method

marcoroth · marcoroth · commit c870ceec609b · 2023-01-24T03:58:36.000+01:00
diff --git a/src/core/controller.ts b/src/core/controller.ts
@@ -8,6 +8,14 @@ import { ValuePropertiesBlessing, ValueDefinitionMap } from "./value_properties"
 
 export type ControllerConstructor = Constructor<Controller>
 
+type DispatchOptions = Partial<{
+  target: Element | Window | Document
+  detail: Object
+  prefix: string
+  bubbles: boolean
+  cancelable: boolean
+}>
+
 export class Controller<ElementType extends Element = Element> {
   static blessings = [
     ClassPropertiesBlessing,
@@ -79,7 +87,13 @@ export class Controller<ElementType extends Element = Element> {
 
   dispatch(
     eventName: string,
-    { target = this.element, detail = {}, prefix = this.identifier, bubbles = true, cancelable = true } = {}
+    {
+      target = this.element,
+      detail = {},
+      prefix = this.identifier,
+      bubbles = true,
+      cancelable = true,
+    }: DispatchOptions = {}
   ) {
     const type = prefix ? `${prefix}:${eventName}` : eventName
     const event = new CustomEvent(type, { detail, bubbles, cancelable })
