Fix: null-check in isDocument #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrynko
approved these changes
Feb 19, 2025
Owner
hrynko
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix @NicolaiHorlacher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue in the #225 PR i created some time ago.
The
useVuePdfEmbedcomposable can handlenullvalues in the source filed just fine (even when not explicitly typed).With the exception of the
isDocumentfunction I added.I refined the
isDocumentfunction to include type guards and handlenullvalues more gracefully.To avoid a Typescript issue (vuejs/core#11360) I upgraded the
vuedevDependency to v3.5.The vue peerDependency can stay at v3.3, because no new features of vue are used.