fix(htmlhint.ts): replace deprecated request module with what-wg fetch #670
Conversation
|
Please link this pull request to the issue raised here: |
|
@darcyparker - this fix appears to have stalled, i think because by the time it was reviewed there are conflicts. I wonder if you could spare the time to resolve the conflicts and do another pull request to get some movement on this? |
09b5fe4 to
581815c
Compare
|
@stuartbale - Yes, at the time of review, the |
|
build/test is failing - can you take a look @thedaviddias @darcyparker ? |
|
@coliff - I am looking at it now. |
Replace deprecated request module with what-wg fetch.
581815c to
352d965
Compare
|
The build/test issue was node-fetch v3. Because this repo builds commonjs, I needed to use v2. (https://github.com/node-fetch/node-fetch#loading-and-configuring-the-module) v3 is only 15 days old (as of now)... so I missed this when I rebased and reinstalled node-fetch. I believe the tests will pass now. |
5e3e52e to
8789eca
Compare
|
FYI: I added node-fetch types for v2 as dev dependency. |
Thanks for doing that work @darcyparker 🙏 |
## [0.15.2](v0.15.1...v0.15.2) (2021-09-16) ### Bug Fixes * **htmlhint.ts:** replace deprecated request module with what-wg fetch ([#670](#670)) ([250169d](250169d))
Short description of what this resolves:
Replaces the deprecated request module with fetch.
Today,
npm installwarns:(
uuidis a dependency ofrequest)Proposed changes:
requestand@types/requestAlthough
fetchhas a more modern async interface, I did not change the interface ofhtmlUrl().htmlUrl()and other fns could be reworked to use more modern async patterns in the future. My main objective is to replace the deprecatedrequestAPI.