Generalize PagedQuery to allow queries of any foldable semigroup.

Thomas M. DuBuisson · Thomas M. DuBuisson · commit c705c34e9fcd · 2020-04-27T22:46:27.000-07:00
diff --git a/src/GitHub/Data/Request.hs b/src/GitHub/Data/Request.hs
@@ -154,7 +154,7 @@ instance IReadOnly 'RA        where iro = ROA
 -- /Note:/ 'Request' is not 'Functor' on purpose.
 data GenRequest (mt :: MediaType *) (rw :: RW) a where
     Query        :: Paths -> QueryString -> GenRequest mt rw a
-    PagedQuery   :: Paths -> QueryString -> FetchCount -> GenRequest mt rw (Vector a)
+    PagedQuery   :: (a ~ t b, Foldable t, Semigroup a) => Paths -> QueryString -> FetchCount -> GenRequest mt rw a
 
     -- | Command
     Command
diff --git a/src/GitHub/Request.hs b/src/GitHub/Request.hs
@@ -100,7 +100,6 @@ import qualified Data.ByteString              as BS
 import qualified Data.ByteString.Lazy         as LBS
 import qualified Data.Text                    as T
 import qualified Data.Text.Encoding           as TE
-import qualified Data.Vector                  as V
 import qualified Network.HTTP.Client          as HTTP
 import qualified Network.HTTP.Client.Internal as HTTP
 
@@ -242,7 +241,7 @@ executeRequestWithMgrAndRes mgr auth req = runExceptT $ do
     performHttpReq httpReq (PagedQuery _ _ l) =
         unTagged (performPagedRequest httpLbs' predicate httpReq :: Tagged mt (ExceptT Error IO (HTTP.Response b)))
       where
-        predicate v = lessFetchCount (V.length v) l
+        predicate v = lessFetchCount (length v) l
 
     performHttpReq httpReq (Command _ _ _) = do
         res <- httpLbs' httpReq
